Set thread name in MSVC debugger.

Set thread name in MSVC debugger.

[Albert Zeyer, 2014-03-20 10:48:38]

Hi,

That's my first patch for V8. I thought this can be useful when you debug V8 in
the MSVC debugger.

Note that you can do the same also on most other platforms, e.g. there is
pthread_setname_np. I'm usually doing this:


#ifdef HAVE_PTHREAD_NAME
//
http://stackoverflow.com/questions/2369738/can-i-set-the-name-of-a-thread-in-...
#ifdef __APPLE__
	pthread_setname_np(name.c_str());
#else
	pthread_setname_np(pthread_self(), name.c_str());
#endif
#endif


I can submit separate patches, if there is interest for it.

Regards,
Albert

[tfarina, 2014-03-20 17:42:21]

+Benedikt for review!

https://codereview.chromium.org/206253003/diff/20001/src/platform-win32.cc
File src/platform-win32.cc (right):

https://codereview.chromium.org/206253003/diff/20001/src/platform-win32.cc#ne...
src/platform-win32.cc:1426: static void setCurThreadName(const char* name) {
I think our style is to use CamelCase, so please, name this
SetCurrentThreadName.

thanks!

[Benedikt Meurer, 2014-03-31 06:57:02]

LGTM, but I'll forward this to Jarin for in-depth review.

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc
File src/platform-win32.cc (right):

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#ne...
src/platform-win32.cc:1426: static void SetCurThreadName(const char* name) {
Nit: Use SetCurrentThreadName()

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#ne...
src/platform-win32.cc:1437: {
Nit: no need for a {}-block here.

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#ne...
src/platform-win32.cc:1440: info.dwThreadID = (DWORD)-1;
Use static_cast<DWORD>(-1)

[Jarin, 2014-03-31 07:45:59]

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc
File src/platform-win32.cc (right):

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#ne...
src/platform-win32.cc:1426: static void SetCurThreadName(const char* name) {
On 2014/03/31 06:57:02, Benedikt Meurer wrote:
> Nit: Use SetCurrentThreadName()

How about taking the code from Chromium? See
https://code.google.com/p/chromium/codesearch#chromium/src/base/threading/pla...

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#ne...
src/platform-win32.cc:1427: // Reference:
http://www.codeproject.com/KB/threads/Name_threads_in_debugger.aspx

I would prefer to link Microsoft rather than codeproject.com
(http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx).

https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#ne...
src/platform-win32.cc:1447: sizeof(info)/sizeof(DWORD),
reinterpret_cast<ULONG_PTR*>(&info));

The Microsoft article says the third arg should be
sizeof(info)/sizeof(ULONG_PTR). Confusingly, the Chromium source says
sizeof(info)/sizeof(DWORD). Personally, I would trust the Microsoft article (and
suggest a fix to Chromium).