Set thread name in MSVC debugger.

src/platform-win32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1405 matching lines @@
   return false;
 }
 
 
 // ----------------------------------------------------------------------------
 // Win32 thread support.
 
 // Definition of invalid thread handle and id.
 static const HANDLE kNoThread = INVALID_HANDLE_VALUE;
 
+static void SetCurThreadName(const char* name) {

[Benedikt Meurer, 2014/03/31 06:57:02]

Nit: Use SetCurrentThreadName()

[Jarin, 2014/03/31 07:46:00]

How about taking the code from Chromium? See
https://code.google.com/p/chromium/codesearch#chromium/src/base/threading/pla...

+  // Reference: http://www.codeproject.com/KB/threads/Name_threads_in_debugger.aspx

[Jarin, 2014/03/31 07:46:00]

I would prefer to link Microsoft rather than codeproject.com
(http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx).

+
+  typedef struct tagTHREADNAME_INFO {
+    DWORD dwType;  // Must be 0x1000.
+    LPCSTR szName;  // Pointer to name (in user addr space).
+    DWORD dwThreadID;  // Thread ID (-1=caller thread).
+    DWORD dwFlags;  // Reserved for future use, must be zero.
+  } THREADNAME_INFO;
+
+  THREADNAME_INFO info;
+  {

[Benedikt Meurer, 2014/03/31 06:57:02]

Nit: no need for a {}-block here.

+    info.dwType = 0x1000;
+    info.szName = name;
+    info.dwThreadID = (DWORD)-1;

[Benedikt Meurer, 2014/03/31 06:57:02]

Use static_cast<DWORD>(-1)

+    info.dwFlags = 0;
+  }
+
+  __try {
+    RaiseException(
+      0x406D1388 /* MSVC EXCEPTION */, 0,
+      sizeof(info)/sizeof(DWORD), reinterpret_cast<ULONG_PTR*>(&info));

[Jarin, 2014/03/31 07:46:00]

The Microsoft article says the third arg should be
sizeof(info)/sizeof(ULONG_PTR). Confusingly, the Chromium source says
sizeof(info)/sizeof(DWORD). Personally, I would trust the Microsoft article (and
suggest a fix to Chromium).

+  }
+  __except(EXCEPTION_CONTINUE_EXECUTION) {}
+}
+
 // Entry point for threads. The supplied argument is a pointer to the thread
 // object. The entry function dispatches to the run method in the thread
 // object. It is important that this function has __stdcall calling
 // convention.
 static unsigned int __stdcall ThreadEntry(void* arg) {
   Thread* thread = reinterpret_cast<Thread*>(arg);
+  SetCurThreadName(thread->name());
   thread->NotifyStartedAndRun();
   return 0;
 }
 
 
 class Thread::PlatformData : public Malloced {
  public:
   explicit PlatformData(HANDLE thread) : thread_(thread) {}
   HANDLE thread_;
   unsigned thread_id_;
@@ skipping 71 matching lines @@
   ASSERT(result);
 }
 
 
 
 void Thread::YieldCPU() {
   Sleep(0);
 }
 
 } }  // namespace v8::internal