Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 206253002: Revert of Add mechanism to auto mount file systems in response to a URL request. (Closed)

Created:
6 years, 9 months ago by pneubeck (no reviews)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), tzik, Lei Zhang, jam, nhiroki, joi+watch-content_chromium.org, tommycli, darin-cc_chromium.org, Greg Billock, kinuko+watch, mtomasz
Visibility:
Public.

Description

Revert of Add mechanism to auto mount file systems in response to a URL request. (https://codereview.chromium.org/195923002/) Reason for revert: Best guess that this broke SyncFileSystemApiTest.WriteFileThenGetUsage SyncFileSystemApiTest.GetFileStatuses MediaGalleriesPlatformAppBrowserTest.MediaGalleriesCopyTo on XP Tests(1). Original issue's description: > Add mechanism to auto mount file systems in response to a URL request. > > This code adds a hook for when a file system URL request can not be cracked. > It will allow external media galleries file systems to be lazily created. > > BUG=160900 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258064 TBR=kinuko@chromium.org,tzik@chromium.org,joi@chromium.org,sky@chromium.org,vandebo@chromium.org NOTREECHECKS=true NOTRY=true BUG=160900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -396 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 9 chunks +5 lines, -116 lines 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 7 chunks +2 lines, -92 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_file_system_context.h View 3 chunks +1 line, -8 lines 0 comments Download
M content/public/test/test_file_system_context.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M webkit/browser/fileapi/external_mount_points.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 6 chunks +0 lines, -30 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.h View 2 chunks +3 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_factory.h View 2 chunks +1 line, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_factory.cc View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pneubeck (no reviews)
Created Revert of Add mechanism to auto mount file systems in response to a URL ...
6 years, 9 months ago (2014-03-20 10:00:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/206253002/1
6 years, 9 months ago (2014-03-20 10:00:22 UTC) #2
commit-bot: I haz the power
Change committed as 258261
6 years, 9 months ago (2014-03-20 10:01:24 UTC) #3
vandebo (ex-Chrome)
6 years, 9 months ago (2014-03-20 16:38:13 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/199903003/ by vandebo@chromium.org.

The reason for reverting is: This revert did not fix the breakage it was
suspected of..

Powered by Google App Engine
This is Rietveld 408576698