content/browser/session_history_browsertest.cc - Issue 2062523002: Fixing renderer's access to a file from HTTP POST (after a xsite transfer).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/session_history_browsertest.cc

Issue 2062523002: Fixing renderer's access to a file from HTTP POST (after a xsite transfer). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary logging + simplified condition of an "if" statement. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/common/resource_request_body.h » ('j') | content/common/resource_request_body.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/session_history_browsertest.cc

diff --git a/content/browser/session_history_browsertest.cc b/content/browser/session_history_browsertest.cc

index acd569d6c8ab44079541faaf1b4ebb1ede4f9160..4f801271466e52bf2451c775a38dc905f70292d9 100644

--- a/content/browser/session_history_browsertest.cc

+++ b/content/browser/session_history_browsertest.cc

@@ -506,7 +506,7 @@ IN_PROC_BROWSER_TEST_F(SessionHistoryTest, HistoryLength) {

// redirects (as mandated by https://tools.ietf.org/html/rfc7231#section-6.4.7).

IN_PROC_BROWSER_TEST_F(SessionHistoryTest, GoBackToCrossSitePostWithRedirect) {

GURL form_url(embedded_test_server()->GetURL(

- "a.com", "/session_history/form_that_posts_cross_site.html"));

+ "a.com", "/form_that_posts_cross_site.html"));

GURL redirect_target_url(embedded_test_server()->GetURL("x.com", "/echoall"));

GURL page_to_go_back_from(

embedded_test_server()->GetURL("c.com", "/title1.html"));

@@ -518,7 +518,7 @@ IN_PROC_BROWSER_TEST_F(SessionHistoryTest, GoBackToCrossSitePostWithRedirect) {

// Submit the form.

TestNavigationObserver form_post_observer(shell()->web_contents(), 1);

EXPECT_TRUE(

- ExecuteScript(shell(), "document.getElementById('form').submit();"));

+ ExecuteScript(shell(), "document.getElementById('text-form').submit();"));

form_post_observer.Wait();

// Verify that we arrived at the expected, redirected location.