content/browser/renderer_host/render_view_host_impl.cc - Issue 2062523002: Fixing renderer's access to a file from HTTP POST (after a xsite transfer).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2062523002: Fixing renderer's access to a file from HTTP POST (after a xsite transfer). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary logging + simplified condition of an "if" statement. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/session_history_browsertest.cc » ('j') | content/common/resource_request_body.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 84d790eabf8db891f818da53fe9f0021fc594714..c1abb1831ea43140796f906e2eecb85bb1afbe7b 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1246,15 +1246,8 @@ void RenderViewHostImpl::OnFocusedNodeTouched(bool editable) {

bool RenderViewHostImpl::CanAccessFilesOfPageState(

const PageState& state) const {

- ChildProcessSecurityPolicyImpl* policy =

- ChildProcessSecurityPolicyImpl::GetInstance();

- const std::vector<base::FilePath>& file_paths = state.GetReferencedFiles();

- for (const auto& file : file_paths) {

- if (!policy->CanReadFile(GetProcess()->GetID(), file))

- return false;

- }

- return true;

+ return ChildProcessSecurityPolicyImpl::GetInstance()->CanReadAllFiles(

+ GetProcess()->GetID(), state.GetReferencedFiles());

}

void RenderViewHostImpl::GrantFileAccessFromPageState(const PageState& state) {