Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2062483002: Revert of Add LeakDetectorRemoteController as a Mojo service (Closed)

Created:
4 years, 6 months ago by Simon Que
Modified:
4 years, 6 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add LeakDetectorRemoteController as a Mojo service (patchset #6 id:100001 of https://codereview.chromium.org/2030883004/ ) Reason for revert: Need to re-submit mojom interface and implementation in single CL, and get security review from IPC owners. Original issue's description: > Add LeakDetectorRemoteController as a Mojo service > > New class LeakDetectorRemoteController that implements the Mojo > interface LeakDetectorRemote. This class provides a bridge between the > browser and renderer processes. It also allows a single instance of > LeakDetectorController to provide leak detector params to the renderer > process and receive leak reports from the renderer process. > > The renderer process client will be implemented in a future CL. > > BUG=chromium:615223 > > Committed: https://crrev.com/23bcb38936fddb66a15c02315d05d62e529756d4 > Cr-Commit-Position: refs/heads/master@{#398775} TBR=jochen@chromium.org,asvitkine@chromium.org,isherman@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:615223 Committed: https://crrev.com/60265ec8d4f168ebb46a649613a5ee91715f7139 Cr-Commit-Position: refs/heads/master@{#399355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -157 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/metrics/leak_detector/leak_detector_controller.h View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/metrics/leak_detector/leak_detector_controller.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Simon Que
Created Revert of Add LeakDetectorRemoteController as a Mojo service
4 years, 6 months ago (2016-06-10 21:51:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062483002/1
4 years, 6 months ago (2016-06-10 21:53:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-10 21:53:03 UTC) #5
Simon Que
4 years, 6 months ago (2016-06-10 21:56:26 UTC) #7
Will Harris
lgtm but not sure why this is needed, unless sque@ is not a committer.
4 years, 6 months ago (2016-06-10 21:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062483002/1
4 years, 6 months ago (2016-06-10 21:59:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/86170)
4 years, 6 months ago (2016-06-10 23:44:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062483002/1
4 years, 6 months ago (2016-06-11 02:04:21 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-11 02:32:45 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 02:33:57 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60265ec8d4f168ebb46a649613a5ee91715f7139
Cr-Commit-Position: refs/heads/master@{#399355}

Powered by Google App Engine
This is Rietveld 408576698