Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h

Issue 2062483002: Revert of Add LeakDetectorRemoteController as a Mojo service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
deleted file mode 100644
index 407347414f31d184b9332a23189570a39d2bd695..0000000000000000000000000000000000000000
--- a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_REMOTE_CONTROLLER_H_
-#define CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_REMOTE_CONTROLLER_H_
-
-#include <string>
-#include <vector>
-
-#include "base/macros.h"
-#include "components/metrics/leak_detector/leak_detector_remote.mojom.h"
-#include "components/metrics/proto/memory_leak_report.pb.h"
-#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
-
-namespace metrics {
-
-// This class acts as an interface to LeakDetector clients running on processes
-// other than its own (the browser process).
-class LeakDetectorRemoteController : public LeakDetectorRemote {
- public:
- // Interface class to be implemented by a local controller class that provides
- // leak detector parameters and can pass leak reports to UMA.
- class LocalController {
- public:
- virtual ~LocalController() {}
-
- // Returns a set of leak detection params to be used when initializing the
- // leak detector on a remote process.
- virtual MemoryLeakReportProto::Params GetParams() const = 0;
-
- // Pass a vector of memory leak reports provided by a remote process to the
- // local controller class.
- virtual void SendLeakReports(
- const std::vector<MemoryLeakReportProto>& reports) = 0;
- };
-
- ~LeakDetectorRemoteController() override;
-
- static void Create(LeakDetectorRemoteRequest request);
-
- // LeakDetectorRemote:
- void GetParams(
- const LeakDetectorRemote::GetParamsCallback& callback) override;
- void SendLeakReports(mojo::Array<mojo::String>) override;
-
- // Sets a global pointer to a LocalController implementation. The global
- // pointer is defined in the .cc file.
- static void SetLocalControllerInstance(LocalController* controller);
-
- private:
- explicit LeakDetectorRemoteController(LeakDetectorRemoteRequest request);
-
- mojo::StrongBinding<metrics::LeakDetectorRemote> binding_;
-
- DISALLOW_COPY_AND_ASSIGN(LeakDetectorRemoteController);
-};
-
-} // namespace metrics
-
-#endif // CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_REMOTE_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698