mojo::Callback -> base::Callback

mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
TBR=ben@chromium.org for general/toplevel
TBR=xhwang@chromium.org for media related changes

Committed: https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de
Cr-Commit-Position: refs/heads/master@{#400598}

[Ken Rockot(use gerrit already), 2016-06-15 08:41:20]

Description was changed from

==========
No Callback!

BUG=
==========

to

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

The mojo::Callback and mojo::Closure symbols are left
in place as aliases for the names in base until all
references can be updated.

The bulk of this CL is converting lambda usage
to base::Bind calls.

mojo::Callback also allowed a bit more flexibility on
response callback signatures, e.g. a mojo::String
argument could be received as a std::string or 
const mojo::String& or other compatible types. This
flexibility is no longer available so various response
callback signatures have been updated to match the
bindings signatures exactly.

mojo::Callback::Run also silently ignored calls on
unbound callbacks, so many call sites have been updated
to test is_null() first.

Finally, reset() -> Reset().

BUG=None
==========

[Ken Rockot(use gerrit already), 2016-06-16 20:01:11]

Description was changed from

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

The mojo::Callback and mojo::Closure symbols are left
in place as aliases for the names in base until all
references can be updated.

The bulk of this CL is converting lambda usage
to base::Bind calls.

mojo::Callback also allowed a bit more flexibility on
response callback signatures, e.g. a mojo::String
argument could be received as a std::string or 
const mojo::String& or other compatible types. This
flexibility is no longer available so various response
callback signatures have been updated to match the
bindings signatures exactly.

mojo::Callback::Run also silently ignored calls on
unbound callbacks, so many call sites have been updated
to test is_null() first.

Finally, reset() -> Reset().

BUG=None
==========

to

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
==========

[Ken Rockot(use gerrit already), 2016-06-16 20:21:30]

rockot@chromium.org changed reviewers:
+ lhchavez@chromium.org, yzshen@chromium.org

[Ken Rockot(use gerrit already), 2016-06-16 20:21:32]

Yuzhu could you please take a look at mojo/public?

+lhchavez for components/arc and chrome/browser/chromeos/arc

[Luis Héctor Chávez, 2016-06-16 20:28:00]

components/arc and chrome/browser/chromeos/arc lgtm

[Ken Rockot(use gerrit already), 2016-06-16 20:28:32]

Description was changed from

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
==========

to

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
==========

[yzshen1, 2016-06-18 00:01:18]

mojo/public LGTM

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/callback.h (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/callback.h:13: using Callback = base::Callback<Sig>;
Woohoo!

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/strong_binding.h (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/strong_binding.h:112: RunConnectionErrorHandler();
nit: maybe no need to have such a helper because this method is the only user.

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/handle_passing_unittest.cc (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/handle_passing_unittest.cc:26: *storage =
str.To<std::string>();
nit: str.PassStorage()

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/sync_method_unittest.cc (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/sync_method_unittest.cc:23: struct LambdaBinder {
optional: Can this be shared with other tests? I like the way how lambda
simplified our testing code.

[Ken Rockot(use gerrit already), 2016-06-18 03:24:20]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-18 03:24:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2062333002/#ps100001
(title: ".")

[Ken Rockot(use gerrit already), 2016-06-18 03:24:26]

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/strong_binding.h (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/strong_binding.h:112: RunConnectionErrorHandler();
On 2016/06/18 at 00:01:18, yzshen1 wrote:
> nit: maybe no need to have such a helper because this method is the only user.

Oops, done.

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/handle_passing_unittest.cc (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/handle_passing_unittest.cc:26: *storage =
str.To<std::string>();
On 2016/06/18 at 00:01:18, yzshen1 wrote:
> nit: str.PassStorage()

Done

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/sync_method_unittest.cc (right):

https://codereview.chromium.org/2062333002/diff/80001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/sync_method_unittest.cc:23: struct LambdaBinder {
On 2016/06/18 at 00:01:18, yzshen1 wrote:
> optional: Can this be shared with other tests? I like the way how lambda
simplified our testing code.

I would like to think so but decided against it for now since most tests can do
just fine without any such magic. Maybe in the future we could generate lambda
binding helpers for mojom methods, e.g. for a FooCallback we could generate a
FooCallbackBinder which tries to bind an arbitrary lambda to match Foo's
signature.

[commit-bot: I haz the power, 2016-06-18 03:24:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062333002/100001

[haraken, 2016-06-18 03:25:21]

WebKit LGTM

[commit-bot: I haz the power, 2016-06-18 03:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 03:33:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-06-18 03:50:20]

Description was changed from

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
==========

to

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
TBR=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-06-18 03:50:20]

rockot@chromium.org changed reviewers:
+ haraken@chromium.org

[Ken Rockot(use gerrit already), 2016-06-18 18:07:33]

Description was changed from

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
TBR=ben@chromium.org
==========

to

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
TBR=ben@chromium.org for general/toplevel
TBR=xhwang@chromium.org for media related changes
==========

[Ken Rockot(use gerrit already), 2016-06-18 19:35:56]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-18 19:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, lhchavez@chromium.org, yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2062333002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-18 19:36:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062333002/120001

[commit-bot: I haz the power, 2016-06-18 20:16:06]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-18 20:18:27]

Description was changed from

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
TBR=ben@chromium.org for general/toplevel
TBR=xhwang@chromium.org for media related changes
==========

to

==========
mojo::Callback -> base::Callback

Replaces mojo::Callback with base::Callback.

This means updating several callback sites for the
following reasons:

- The mojo::Callback<T>::Runnable interface no longer exists
- C++11 lambas may no longer be bound implicitly
- Repsonse callback signatures must now match the generated
  signature exactly (i.e. no implicit conversion from
  const mojo::String& or const std::string& to a by-value
  mojo::String)
- Null mojo::Callbacks could be Run without crashing; this
  is no longer true.
- It's base::Callback::Reset instead of mojo::Callback::reset

mojo::Callback and mojo::Closure are left in place as aliases
for base::Callback and base::Closure until all references can
be updated.

BUG=620840
TBR=ben@chromium.org for general/toplevel
TBR=xhwang@chromium.org for media related changes

Committed: https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de
Cr-Commit-Position: refs/heads/master@{#400598}
==========

[commit-bot: I haz the power, 2016-06-18 20:18:29]

Patchset 7 (id:??) landed as
https://crrev.com/c383dde80197ffd21e23d89eddf0b7a4d819a3de
Cr-Commit-Position: refs/heads/master@{#400598}