chrome/browser/usb/usb_chooser_controller.cc - Issue 2062333002: mojo::Callback -> base::Callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/usb_chooser_controller.cc

Issue 2062333002: mojo::Callback -> base::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/usb/usb_chooser_controller.cc

diff --git a/chrome/browser/usb/usb_chooser_controller.cc b/chrome/browser/usb/usb_chooser_controller.cc

index b5ed31397ce7a011b52f849258034e19c79018f2..29a8b9a4ff93b4f8860e18784a3c0724196b7701 100644

--- a/chrome/browser/usb/usb_chooser_controller.cc

+++ b/chrome/browser/usb/usb_chooser_controller.cc

@@ -95,7 +95,7 @@ void UsbChooserController::Select(size_t index) {

device::usb::DeviceInfoPtr device_info_ptr =

device::usb::DeviceInfo::From(*devices_[index].first);

callback_.Run(std::move(device_info_ptr));

- callback_.reset(); // Reset |callback_| so that it is only run once.

+ callback_.Reset(); // Reset |callback_| so that it is only run once.

RecordWebUsbChooserClosure(

devices_[index].first->serial_number().empty()