Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 2062323003: [tools] make ic-explorer deal with empty map records from --trace-ic (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] make ic-explorer deal with empty map records from --trace-ic BUG= Committed: https://crrev.com/13d08bc338456bbe363b516bf57b5796be63a3c1 Cr-Commit-Position: refs/heads/master@{#37025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/ic-explorer.html View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL
4 years, 6 months ago (2016-06-15 12:20:04 UTC) #3
nickie
lgtm
4 years, 6 months ago (2016-06-15 15:45:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062323003/1
4 years, 6 months ago (2016-06-16 06:43:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 07:06:55 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 07:08:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13d08bc338456bbe363b516bf57b5796be63a3c1
Cr-Commit-Position: refs/heads/master@{#37025}

Powered by Google App Engine
This is Rietveld 408576698