Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: tools/ic-explorer.html

Issue 2062323003: [tools] make ic-explorer deal with empty map records from --trace-ic (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ic-explorer.html
diff --git a/tools/ic-explorer.html b/tools/ic-explorer.html
index 8e5d4bd13ae994d4c32bbae79f9cc3aac8365626..42bbc2039618a3e7aead36733f0ec68b5ebefff2 100644
--- a/tools/ic-explorer.html
+++ b/tools/ic-explorer.html
@@ -71,7 +71,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
if (offset == -1) return
this.state = parts[++offset];
this.map = parts[offset + 1];
- if (this.map.startsWith("map=")) {
+ if (this.map !== undefined && this.map.startsWith("map=")) {
this.map = this.map.substring(4);
offset++;
} else {
@@ -217,6 +217,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
function escapeHtml(unsafe) {
+ if (!unsafe) return "";
return unsafe.toString()
.replace(/&/g, "&")
.replace(/</g, "&lt;")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698