Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: LayoutTests/fast/events/xhr-onclick-crash.html

Issue 206223005: Forbid setting responseType on all sync XHRs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix tests that set responseType on sync XHRs. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/xhr-onclick-crash.html
diff --git a/LayoutTests/fast/events/xhr-onclick-crash.html b/LayoutTests/fast/events/xhr-onclick-crash.html
index 23d152ea02a1d7a22797af6c44f55f2c9c020882..8313295ca8bc68e52ac7f24a9ea94d2623eff9b6 100644
--- a/LayoutTests/fast/events/xhr-onclick-crash.html
+++ b/LayoutTests/fast/events/xhr-onclick-crash.html
@@ -3,11 +3,15 @@ This test passes if it doesn't crash.
if (window.testRunner)
testRunner.dumpAsText();
+window.jsTestIsAsync = true;
Nate Chapin 2014/03/20 19:59:56 I don't think this does what you want it to. This
davidben 2014/03/20 20:05:00 Done.
xhr = new XMLHttpRequest();
-xhr.open('GET', 'resources/onclick.html', false);
+xhr.open('GET', 'resources/onclick.html', true);
xhr.responseType = 'document';
-xhr.onload = function () { r = this.responseXML; }
+xhr.onload = function () {
+ var r = this.responseXML;
+ var td = r.getElementById('foo');
+ td.children[0].onclick;
+ finishJSTest();
+};
xhr.send();
-td = r.getElementById('foo');
-td.children[0].onclick;
</script>
« no previous file with comments | « LayoutTests/fast/events/event-on-xhr-document.html ('k') | LayoutTests/fast/html/imports/import-defaultView.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698