LayoutTests/fast/events/xhr-onclick-crash.html - Issue 206223005: Forbid setting responseType on all sync XHRs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/xhr-onclick-crash.html

Issue 206223005: Forbid setting responseType on all sync XHRs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests that set responseType on sync XHRs. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 This test passes if it doesn't crash.	1 This test passes if it doesn't crash.

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner)

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

5	5

	6 window.jsTestIsAsync = true;
	Nate Chapin 2014/03/20 19:59:56 I don't think this does what you want it to. This I don't think this does what you want it to. This is a no-op if the test doesn't use js-test.js. You need to call testRunner.waitUntilDone() here and testRunnery.notifyDone() instead of finishJSTest(). davidben 2014/03/20 20:05:00 Done. Show quoted text On 2014/03/20 19:59:56, Nate Chapin wrote: > I don't think this does what you want it to. This is a no-op if the test doesn't > use js-test.js. You need to call testRunner.waitUntilDone() here and > testRunnery.notifyDone() instead of finishJSTest(). Done.
6 xhr = new XMLHttpRequest();	7 xhr = new XMLHttpRequest();

7 xhr.open('GET', 'resources/onclick.html', false);	8 xhr.open('GET', 'resources/onclick.html', true);

8 xhr.responseType = 'document';	9 xhr.responseType = 'document';

9 xhr.onload = function () { r = this.responseXML; }	10 xhr.onload = function () {

	11 var r = this.responseXML;

	12 var td = r.getElementById('foo');

	13 td.children[0].onclick;

	14 finishJSTest();

	15 };

10 xhr.send();	16 xhr.send();

11 td = r.getElementById('foo');

12 td.children[0].onclick;

13 </script>	17 </script>

OLD	NEW