Forbid setting responseType on all sync XHRs.

Forbid setting responseType on all sync XHRs.

Rather than only doing it for http(s) URLs. This matches the XHR2 spec and
Firefox. This also avoids having to support the downloadToFile + synchronous
load combination in the resource loader stack.

Update tests according and add an assertion.

BUG=354188
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169702

[Nate Chapin, 2014-03-20 18:28:52]

LGTM

[davidben, 2014-03-20 18:50:13]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-03-20 18:50:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/206223005/1

[commit-bot: I haz the power, 2014-03-20 18:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 18:59:18]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[davidben, 2014-03-20 19:28:02]

Apparently we had some tests that did this. Updated accordingly and sent off
some try jobs to double-check. I don't think the synchronicity was relevant for
any of the tests; they're more about documents not attached to anything than
handling responseType synchronously.

[Nate Chapin, 2014-03-20 19:59:56]

LGTM after the test is fixed.

https://codereview.chromium.org/206223005/diff/10001/LayoutTests/fast/events/...
File LayoutTests/fast/events/xhr-onclick-crash.html (right):

https://codereview.chromium.org/206223005/diff/10001/LayoutTests/fast/events/...
LayoutTests/fast/events/xhr-onclick-crash.html:6: window.jsTestIsAsync = true;
I don't think this does what you want it to. This is a no-op if the test doesn't
use js-test.js. You need to call testRunner.waitUntilDone() here and
testRunnery.notifyDone() instead of finishJSTest().

[davidben, 2014-03-20 20:05:00]

https://codereview.chromium.org/206223005/diff/10001/LayoutTests/fast/events/...
File LayoutTests/fast/events/xhr-onclick-crash.html (right):

https://codereview.chromium.org/206223005/diff/10001/LayoutTests/fast/events/...
LayoutTests/fast/events/xhr-onclick-crash.html:6: window.jsTestIsAsync = true;
On 2014/03/20 19:59:56, Nate Chapin wrote:
> I don't think this does what you want it to. This is a no-op if the test
doesn't
> use js-test.js. You need to call testRunner.waitUntilDone() here and
> testRunnery.notifyDone() instead of finishJSTest().

Done.

[davidben, 2014-03-20 20:05:12]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-03-20 20:05:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/206223005/30001

[commit-bot: I haz the power, 2014-03-20 20:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 20:07:20]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[davidben, 2014-03-20 20:09:19]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-03-20 20:09:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/206223005/30001

[commit-bot: I haz the power, 2014-03-20 21:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 21:13:35]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[davidben, 2014-03-20 21:38:02]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-03-20 21:38:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/206223005/30001

[commit-bot: I haz the power, 2014-03-20 21:57:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/206223005/30001

[commit-bot: I haz the power, 2014-03-20 22:42:10]

Change committed as 169702