Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2062213002: Removing the check for SM_TABLETPC for determining whether a device is operating as a tablet. (Closed)

Created:
4 years, 6 months ago by ananta
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Removing the check for SM_TABLETPC for determining whether a device is operating as a tablet. Merging to M51 That appears to always return false on Windows 10 regardless of what mode the device is in (tablet mode) or desktop mode without a keyboard. This should fix the issues folks are reporting with the keyboard not popping up when we detach a keyboard with tablet mode off. BUG=497381 Review URL: https://codereview.chromium.org/1879953002 Cr-Commit-Position: refs/heads/master@{#386700} (cherry picked from commit 10b82fbb3ecde7460928ba2cc18664eb8f42865c) Committed: https://chromium.googlesource.com/chromium/src/+/81c64195a60e576ffe19cb607555f33d3d4b6164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/win/win_util.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ananta
4 years, 6 months ago (2016-06-14 19:56:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81c64195a60e576ffe19cb607555f33d3d4b6164.

Powered by Google App Engine
This is Rietveld 408576698