Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1879953002: Removing the check for SM_TABLETPC for determining whether a device is operating as a tablet. (Closed)

Created:
4 years, 8 months ago by ananta
Modified:
4 years, 8 months ago
Reviewers:
jschuh
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing the check for SM_TABLETPC for determining whether a device is operating as a tablet. That appears to always return false on Windows 10 regardless of what mode the device is in (tablet mode) or desktop mode without a keyboard. This should fix the issues folks are reporting with the keyboard not popping up when we detach a keyboard with tablet mode off. BUG=497381 Committed: https://crrev.com/10b82fbb3ecde7460928ba2cc18664eb8f42865c Cr-Commit-Position: refs/heads/master@{#386700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/win/win_util.cc View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
ananta
4 years, 8 months ago (2016-04-12 01:24:23 UTC) #2
jschuh
lgtm
4 years, 8 months ago (2016-04-12 15:26:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879953002/1
4 years, 8 months ago (2016-04-12 15:27:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 15:57:57 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 15:59:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10b82fbb3ecde7460928ba2cc18664eb8f42865c
Cr-Commit-Position: refs/heads/master@{#386700}

Powered by Google App Engine
This is Rietveld 408576698