IDBObserver: Lifetime Management: Adding Observer

content/browser/indexed_db/indexed_db_transaction.cc

Index: content/browser/indexed_db/indexed_db_transaction.cc
diff --git a/content/browser/indexed_db/indexed_db_transaction.cc b/content/browser/indexed_db/indexed_db_transaction.cc
index a7f17b6178c24bf5c0675393ed399c392177d648..ab28a977cf8ccf66aad9bacb765b4a8557abc1e6 100644
--- a/content/browser/indexed_db/indexed_db_transaction.cc
+++ b/content/browser/indexed_db/indexed_db_transaction.cc
@@ -14,6 +14,7 @@
 #include "content/browser/indexed_db/indexed_db_cursor.h"
 #include "content/browser/indexed_db/indexed_db_database.h"
 #include "content/browser/indexed_db/indexed_db_database_callbacks.h"
+#include "content/browser/indexed_db/indexed_db_observer.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseException.h"
@@ -314,6 +315,9 @@ leveldb::Status IndexedDBTransaction::CommitPhaseTwo() {
   database_->transaction_coordinator().DidFinishTransaction(this);
 
   if (committed) {
+    // TODO (palakj) : Send Observations to observers
+    if (!pending_observers_.empty())
+      AddActiveObserver();
     abort_task_stack_.clear();
     {
       IDB_TRACE1(
@@ -420,4 +424,15 @@ void IndexedDBTransaction::CloseOpenCursors() {
   open_cursors_.clear();
 }
 
+void IndexedDBTransaction::AddPendingObserver(
+    std::unique_ptr<IndexedDBObserver> observer) {
+  pending_observers_.emplace_back(std::move(observer));

[Marijn Kruisselbrink, 2016/06/15 13:14:57]

why emplace_back? You probably just want push_back.

[palakj1, 2016/06/16 07:05:40]

Changed. Never knew the difference between emplace_back and push_back uptil now.

+}
+
+void IndexedDBTransaction::AddActiveObserver() {
+  for (size_t i = 0; i < pending_observers_.size(); i++) {
+    database_->active_observers_.emplace_back(std::move(pending_observers_[i]));

[Marijn Kruisselbrink, 2016/06/15 13:14:57]

Same here, this should probably just be push_back

[palakj1, 2016/06/16 07:05:40]

Done

+  }
+}
+
 }  // namespace content