IDBObserver: Lifetime Management: Adding Observer

content/browser/indexed_db/indexed_db_transaction.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_transaction.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 #include "content/browser/indexed_db/indexed_db_cursor.h"
 #include "content/browser/indexed_db/indexed_db_database.h"
 #include "content/browser/indexed_db/indexed_db_database_callbacks.h"
+#include "content/browser/indexed_db/indexed_db_observer.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseException.h"
 #include "third_party/leveldatabase/env_chromium.h"
 
 namespace content {
 
 const int64_t kInactivityTimeoutPeriodSeconds = 60;
 
 IndexedDBTransaction::TaskQueue::TaskQueue() {}
@@ skipping 280 matching lines @@
   // released, and order is critical.
   CloseOpenCursors();
   transaction_->Reset();
 
   // Transactions must also be marked as completed before the
   // front-end is notified, as the transaction completion unblocks
   // operations like closing connections.
   database_->transaction_coordinator().DidFinishTransaction(this);
 
   if (committed) {
+    // TODO (palakj) : Send Observations to observers
+    if (!pending_observers_.empty())
+      AddActiveObserver();
     abort_task_stack_.clear();
     {
       IDB_TRACE1(
           "IndexedDBTransaction::CommitPhaseTwo.TransactionCompleteCallbacks",
           "txn.id", id());
       callbacks_->OnComplete(id_);
     }
     database_->TransactionFinished(this, true);
   } else {
     while (!abort_task_stack_.empty())
@@ skipping 86 matching lines @@
       base::ASCIIToUTF16("Transaction timed out due to inactivity.")));
 }
 
 void IndexedDBTransaction::CloseOpenCursors() {
   IDB_TRACE1("IndexedDBTransaction::CloseOpenCursors", "txn.id", id());
   for (auto* cursor : open_cursors_)
     cursor->Close();
   open_cursors_.clear();
 }
 
+void IndexedDBTransaction::AddPendingObserver(
+    std::unique_ptr<IndexedDBObserver> observer) {
+  pending_observers_.emplace_back(std::move(observer));

[Marijn Kruisselbrink, 2016/06/15 13:14:57]

why emplace_back? You probably just want push_back.

[palakj1, 2016/06/16 07:05:40]

Changed. Never knew the difference between emplace_back and push_back uptil now.

+}
+
+void IndexedDBTransaction::AddActiveObserver() {
+  for (size_t i = 0; i < pending_observers_.size(); i++) {
+    database_->active_observers_.emplace_back(std::move(pending_observers_[i]));

[Marijn Kruisselbrink, 2016/06/15 13:14:57]

Same here, this should probably just be push_back

[palakj1, 2016/06/16 07:05:40]

Done

+  }
+}
+
 }  // namespace content