Issue 2062183002: Fix generation of inner_url in GURL::Replacements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2062183002: Fix generation of inner_url in GURL::Replacements. (Closed)

Created:
4 years, 6 months ago by mmenke

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Fix generation of inner_url in GURL::Replacements. It was being created using a combination of the old and new URLs, instead of just using the new URL. BUG=615820 Review-Url: https://codereview.chromium.org/2029213002 Cr-Commit-Position: refs/heads/master@{#399501} (cherry picked from commit 73cea7e4afe9d7ffc45cecc80da954a481bbb48d) Committed: https://chromium.googlesource.com/chromium/src/+/a586a4f1693ae618c191679d7c16a0de940db67d

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -7 lines)			Patch
M	url/gurl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	url/gurl.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	url/gurl_unittest.cc	View	2 chunks	+22 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

mmenke

4 years, 6 months ago (2016-06-14 18:30:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a586a4f1693ae618c191679d7c16a0de940db67d.