Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2062163004:
MD Settings: make devices open in a new tab rather than clobber current one (Closed)
|
Created:
4 years, 6 months ago by Dan Beam Modified:
4 years, 6 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: make devices open in a new tab rather than clobber current one
R=groby@chromium.org
BUG=619069
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/aabe8b3dfbd28c9b2a017b97de7008c1ccc3fe9e
Cr-Commit-Position: refs/heads/master@{#399841}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (10 generated)
Description was changed from ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 ========== to ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Shiny code of goodness. LGTM https://codereview.chromium.org/2062163004/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/printing_page/printing_page.js (right): https://codereview.chromium.org/2062163004/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/printing_page/printing_page.js:17: window.open(loadTimeData.getString('devicesUrl')); nit: We'll move these strings to $i18n{} at some point, right?
https://codereview.chromium.org/2062163004/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/printing_page/printing_page.js (right): https://codereview.chromium.org/2062163004/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/printing_page/printing_page.js:17: window.open(loadTimeData.getString('devicesUrl')); On 2016/06/14 23:47:00, groby wrote: > nit: We'll move these strings to $i18n{} at some point, right? we only search/replace $i18n{} in html files right now we could do data-url="$i18n{devicesUrl}" and window.open(this.data.url) but that doesn't seem all too much better. also, $i18n{} itself can break complex URLs with ?multi=part&query=params
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062163004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062163004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Description was changed from ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOTRY=true ==========
Description was changed from ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation NOTRY=true ========== to ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062163004/1
Message was sent while issue was closed.
Description was changed from ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: make devices open in a new tab rather than clobber current one R=groby@chromium.org BUG=619069 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aabe8b3dfbd28c9b2a017b97de7008c1ccc3fe9e Cr-Commit-Position: refs/heads/master@{#399841} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/aabe8b3dfbd28c9b2a017b97de7008c1ccc3fe9e Cr-Commit-Position: refs/heads/master@{#399841} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
