Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7347)

Unified Diff: chrome/browser/resources/settings/printing_page/printing_page.js

Issue 2062163004: MD Settings: make devices open in a new tab rather than clobber current one (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/printing_page.js
diff --git a/chrome/browser/resources/settings/printing_page/printing_page.js b/chrome/browser/resources/settings/printing_page/printing_page.js
index 72213f0c6ed5105788bae6d40f0c7bdfc9c85cfc..43df17710df47a5676f54a1713daaad6fc8d5c78 100644
--- a/chrome/browser/resources/settings/printing_page/printing_page.js
+++ b/chrome/browser/resources/settings/printing_page/printing_page.js
@@ -14,6 +14,6 @@ Polymer({
/** @private */
onManageTap_: function() {
- location.href = loadTimeData.getString('devicesUrl');
+ window.open(loadTimeData.getString('devicesUrl'));
groby-ooo-7-16 2016/06/14 23:47:00 nit: We'll move these strings to $i18n{} at some p
Dan Beam 2016/06/14 23:59:14 we only search/replace $i18n{} in html files right
},
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698