Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2062063002: Disable WebViewTest.InterstitialTeardownOnBrowserShutdown on Windows (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebViewTest.InterstitialTeardownOnBrowserShutdown on Windows The test has been flaky recently: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 [848:1216:0614/053522:FATAL:weak_ptr.h(220)] Check failed: get() != nullptr. Backtrace: base::Pickle::Attachment::~Attachment [0x10064967+255016] base::Pickle::Attachment::~Attachment [0x100B36CB+577932] content::ContentRendererClient::GetImageSerializationProcessor [0x113D0F89+13853897] BUG=619508 TBR=mek@chromium.org Committed: https://crrev.com/8458e05a54ad72235f9329863ebb87307ace8291 Cr-Commit-Position: refs/heads/master@{#399708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
4 years, 6 months ago (2016-06-14 14:28:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062063002/1
4 years, 6 months ago (2016-06-14 14:28:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 15:14:58 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 15:15:09 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:52:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8458e05a54ad72235f9329863ebb87307ace8291
Cr-Commit-Position: refs/heads/master@{#399708}

Powered by Google App Engine
This is Rietveld 408576698