chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 2062063002: Disable WebViewTest.InterstitialTeardownOnBrowserShutdown on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2062063002: Disable WebViewTest.InterstitialTeardownOnBrowserShutdown on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index 92be0125f9f916f2e0e0b4348ed1f85f2b124988..47755747eb88ca307d76dcf0f116daf8f7736c4a 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -1540,7 +1540,16 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialTeardown) {

// This test makes sure the browser process does not crash if browser is shut

// down while an interstitial page is being shown in guest.

-IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialTeardownOnBrowserShutdown) {

+// Flaky on Windows. http://crbug.com/619508.

+#if defined(OS_WIN)

+#define MAYBE_InterstitialTeardownOnBrowserShutdown \

+ DISABLED_InterstitialTeardownOnBrowserShutdown

+#else

+#define MAYBE_InterstitialTeardownOnBrowserShutdown \

+ InterstitialTeardownOnBrowserShutdown

+#endif

+IN_PROC_BROWSER_TEST_P(WebViewTest,

+ MAYBE_InterstitialTeardownOnBrowserShutdown) {

InterstitialTeardownTestHelper();

// Now close the app while interstitial page being shown in guest.

« no previous file with comments | « no previous file | no next file » | no next file with comments »