Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index 19519e8bbef38b84dfda78cdf544ce2d531dd29e..00a0bdbb873479e6391b62daec13aea5269f3435 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -769,13 +769,12 @@ class Namer implements ClosureNamer {
} else if (element.kind == ElementKind.SETTER) {
return setterName(element);
} else if (element.kind == ElementKind.FIELD) {
- compiler.internalError(
- 'use instanceFieldPropertyName or instanceFieldAccessorName',
- node: element.parseNode(compiler));
+ compiler.internalError(element,
+ 'Use instanceFieldPropertyName or instanceFieldAccessorName.');
return null;
} else {
- compiler.internalError('getName for bad kind: ${element.kind}',
- node: element.parseNode(compiler));
+ compiler.internalError(element,
+ 'getName for bad kind: ${element.kind}.');
return null;
}
} else {
@@ -811,8 +810,8 @@ class Namer implements ClosureNamer {
globals[element] = result;
return result;
}
- compiler.internalError('getName for unknown kind: ${element.kind}',
- node: element.parseNode(compiler));
+ compiler.internalError(element,
+ 'getName for unknown kind: ${element.kind}.');
return null;
}
}
@@ -1258,7 +1257,7 @@ class ConstantCanonicalHasher implements ConstantVisitor<int> {
}
visitDummy(DummyConstant constant) {
- compiler.internalError(
+ compiler.internalError(NO_LOCATION_SPANNABLE,
'DummyReceiverConstant should never be named and never be subconstant');
}

Powered by Google App Engine
This is Rietveld 408576698