Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: sdk/lib/_internal/compiler/implementation/js/printer.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js/printer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js/printer.dart b/sdk/lib/_internal/compiler/implementation/js/printer.dart
index ef279031e8441354b0d679fbea08d9307b96887d..855eb1d877a169bcc86848f557d3d319e4c95467 100644
--- a/sdk/lib/_internal/compiler/implementation/js/printer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js/printer.dart
@@ -619,7 +619,7 @@ class Printer implements NodeVisitor {
rightPrecedenceRequirement = UNARY;
break;
default:
- compiler.internalError("Forgot operator: $op");
+ compiler.internalError(NO_LOCATION_SPANNABLE, "Forgot operator: $op");
}
visitNestedExpression(left, leftPrecedenceRequirement,
@@ -856,7 +856,8 @@ class Printer implements NodeVisitor {
List<String> parts = template.split('#');
int inputsLength = inputs == null ? 0 : inputs.length;
if (parts.length != inputsLength + 1) {
- compiler.internalError('Wrong number of arguments for JS: $template');
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ 'Wrong number of arguments for JS: $template');
}
// Code that uses JS must take care of operator precedences, and
// put parenthesis if needed.
@@ -872,7 +873,8 @@ class Printer implements NodeVisitor {
}
visitJSExpression(JSExpression node) {
- compiler.internalError('JSPrinter should never see a JSExpression');
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ 'JSPrinter should never see a JSExpression.');
}
visitInterpolatedExpression(InterpolatedExpression node) {
@@ -973,7 +975,7 @@ class DanglingElseVisitor extends BaseVisitor<bool> {
bool visitProgram(Program node) => false;
bool visitNode(Statement node) {
- compiler.internalError("Forgot node: $node");
+ compiler.internalError(NO_LOCATION_SPANNABLE, "Forgot node: $node");
return null;
}

Powered by Google App Engine
This is Rietveld 408576698