Fix a few side panel bugs

Fix a few side panel bugs.

These are subtle bugs in the interactions between components,
so no unit tests.

The metrics-side-panel is now using FailureValue so that value-set-views don't need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

When no rangeOfInterest is selected, then side-panel-container will set
side-panel.rangeOfInterest to an empty Range, causing metrics to produce empty
values. Don't pass rangeOfInterest to metrics if it's empty.

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0ad1a210e258f1b0d0288c394623288aa2747b43

[benjhayden, 2016-06-13 19:35:31]

Description was changed from

==========
Fix a few side panel bugs

BUG=#619462
==========

to

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

BUG=#619462
==========

[benjhayden, 2016-06-13 19:35:42]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2016-06-13 19:35:43]

PTAL :-)

[alexandermont, 2016-06-13 20:56:56]

alexandermont@chromium.org changed reviewers:
+ alexandermont@chromium.org

[alexandermont, 2016-06-13 20:56:57]

lgtm

[benjhayden, 2016-06-13 21:06:52]

Description was changed from

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

BUG=#619462
==========

to

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

These are generally subtle bugs in the interactions between components,
so no unit tests.

BUG=#619462
==========

[benjhayden, 2016-06-13 21:15:16]

Description was changed from

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

These are generally subtle bugs in the interactions between components,
so no unit tests.

BUG=#619462
==========

to

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

These are generally subtle bugs in the interactions between components,
so no unit tests.
==========

[benjhayden, 2016-06-13 21:16:49]

Description was changed from

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

These are generally subtle bugs in the interactions between components,
so no unit tests.
==========

to

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

When no rangeOfInterest is selected, then side-panel-container will set
side-panel.rangeOfInterest to an empty Range, causing metrics to produce empty
values. Don't pass rangeOfInterest to metrics if it's empty.

These are generally subtle bugs in the interactions between components,
so no unit tests.
==========

[benjhayden, 2016-06-13 21:17:14]

Description was changed from

==========
Fix a few side panel bugs.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

When no rangeOfInterest is selected, then side-panel-container will set
side-panel.rangeOfInterest to an empty Range, causing metrics to produce empty
values. Don't pass rangeOfInterest to metrics if it's empty.

These are generally subtle bugs in the interactions between components,
so no unit tests.
==========

to

==========
Fix a few side panel bugs.

These are subtle bugs in the interactions between components,
so no unit tests.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

When no rangeOfInterest is selected, then side-panel-container will set
side-panel.rangeOfInterest to an empty Range, causing metrics to produce empty
values. Don't pass rangeOfInterest to metrics if it's empty.
==========

[eakuefner, 2016-06-13 22:35:24]

lgtm

It's worth mentioning that we don't actually use FailureValues for anything but
this, right now, but that's not a problem for this CL even though it gives me a
headache.

In particular, currently, I think if metrics throw, the map function surfaces it
and MRE translates it to a Failure (which is an MRE concept), but we're
realizing that probably metric running and MRE should be fused in the future.
When that happens, we should deprecate Failure and MreResult in favor of
FailureValue and ValueSet.

[benjhayden, 2016-06-13 23:39:55]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-06-13 23:39:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexandermont@chromium.org
Link to the patchset: https://codereview.chromium.org/2061853002/#ps20001
(title: "set overflow-y:auto on side-panel-container")

[commit-bot: I haz the power, 2016-06-13 23:40:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061853002/20001

[commit-bot: I haz the power, 2016-06-14 01:27:37]

Description was changed from

==========
Fix a few side panel bugs.

These are subtle bugs in the interactions between components,
so no unit tests.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

When no rangeOfInterest is selected, then side-panel-container will set
side-panel.rangeOfInterest to an empty Range, causing metrics to produce empty
values. Don't pass rangeOfInterest to metrics if it's empty.
==========

to

==========
Fix a few side panel bugs.

These are subtle bugs in the interactions between components,
so no unit tests.

The metrics-side-panel is now using FailureValue so that value-set-views don't
need
to handle a separate {set error} method, so ValueSet needs to allow
non-Numeric Values.

input-latency-side-panel didn't actually need to set display=block, which was an
Illegal Invocation that broke the side-panel-container's management of the
"selected" attribute.

The metrics-side-panel forgot to pass |stack| to FailureValue.

value-set-view had some debugging cruft. 

When no rangeOfInterest is selected, then side-panel-container will set
side-panel.rangeOfInterest to an empty Range, causing metrics to produce empty
values. Don't pass rangeOfInterest to metrics if it's empty.

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-14 01:27:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...