Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: tracing/tracing/ui/side_panel/metrics_side_panel.html

Issue 2061853002: Fix a few side panel bugs (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: set overflow-y:auto on side-panel-container Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/side_panel/metrics_side_panel.html
diff --git a/tracing/tracing/ui/side_panel/metrics_side_panel.html b/tracing/tracing/ui/side_panel/metrics_side_panel.html
index 91191608976794b1929d3c341a7c062355ef4da2..80218fb5acbeac33836f569f9ff317e4b87b24b5 100644
--- a/tracing/tracing/ui/side_panel/metrics_side_panel.html
+++ b/tracing/tracing/ui/side_panel/metrics_side_panel.html
@@ -120,7 +120,8 @@ tr.exportTo('tr.ui', function() {
if (!this.model_) {
this.$.results.values = new tr.metrics.ValueSet([
new tr.v.FailureValue('missing', {
- description: 'Missing model'
+ description: 'Missing model',
+ stack: ''
})
]);
return;
@@ -129,10 +130,12 @@ tr.exportTo('tr.ui', function() {
var metric = tr.metrics.MetricRegistry.findTypeInfoWithName(
this.currentMetricName_);
var values = new tr.metrics.ValueSet();
+ var options = {};
+ if (this.rangeOfInterest && !this.rangeOfInterest.isEmpty)
+ options.rangeOfInterest = this.rangeOfInterest;
+
try {
- metric.constructor(values, this.model_, {
- rangeOfInterest: this.rangeOfInterest
- });
+ metric.constructor(values, this.model_, options);
} catch (err) {
this.$.results.values = new tr.metrics.ValueSet([
new tr.v.FailureValue('error', {

Powered by Google App Engine
This is Rietveld 408576698