mash: Move TrayUpdate to //ash/common

mash: Move TrayUpdate to //ash/common

It no longer has aura or ash::Shell dependencies.

Allow +ash/test in ash/common/system/DEPS because it's important for tests to
sit next to their implementation code, even if ash/test hasn't been converted
away from aura yet.

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16
Cr-Commit-Position: refs/heads/master@{#399606}

[James Cook, 2016-06-13 20:56:26]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-13 20:56:27]

msw, please take a look

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/DEPS
File ash/common/system/DEPS (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/DEPS#...
ash/common/system/DEPS:1: # NOTE: Files are migrating to this directory as part
of the mus ash refactor.
I put this file in the wrong place in the previous CL. Most system tray item
implementations are in //ash/system/foo, not //ash/system/tray/foo, so this
needs to live in //ash/common/system.

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update_unittest.cc (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update_unittest.cc:21: TrayUpdate* tray_update =
GetPrimarySystemTray()->GetTrayUpdateForTesting();
AshTestBase::GetPrimarySystemTray() is a dodge around DEPS. I'd like to try to
avoid ash/shell.h from appearing anywhere in the DEPS files under //ash/common,
as I think it will tempt people to continue using it. However, quite a bit of
the tray tests will need to look up a SystemTray from somewhere, and it's going
to be a while before I can move that one. WDYT?

[msw, 2016-06-13 21:18:57]

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/DEPS
File ash/common/system/DEPS (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/DEPS#...
ash/common/system/DEPS:1: # NOTE: Files are migrating to this directory as part
of the mus ash refactor.
On 2016/06/13 20:56:26, James Cook wrote:
> I put this file in the wrong place in the previous CL. Most system tray item
> implementations are in //ash/system/foo, not //ash/system/tray/foo, so this
> needs to live in //ash/common/system.

Acknowledged.

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update.h (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update.h:5: #ifndef
ASH_COMMON_SYSTEM_UPDATE_TRAY_UPDATE_H_
How much more will wind up in the update subfolder? Is it needed?
(why not just keep these files in ash[/common]/system?)

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update_unittest.cc (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update_unittest.cc:21: TrayUpdate* tray_update =
GetPrimarySystemTray()->GetTrayUpdateForTesting();
On 2016/06/13 20:56:26, James Cook wrote:
> AshTestBase::GetPrimarySystemTray() is a dodge around DEPS. I'd like to try to
> avoid ash/shell.h from appearing anywhere in the DEPS files under
//ash/common,
> as I think it will tempt people to continue using it. However, quite a bit of
> the tray tests will need to look up a SystemTray from somewhere, and it's
going
> to be a while before I can move that one. WDYT?


Why not add a WmShell interface function that returns nullptr on mus for now,
and ash::Shell::instance()->GetPrimarySystemTray() for aura? I don't actually
have a strong opinion, this dodge seems fine as a temporary measure, and it's
probably okay to just delay moving the test files until we fix their deps.

[James Cook, 2016-06-13 21:57:19]

msw, does this sound OK?

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update.h (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update.h:5: #ifndef
ASH_COMMON_SYSTEM_UPDATE_TRAY_UPDATE_H_
On 2016/06/13 21:18:57, msw wrote:
> How much more will wind up in the update subfolder? Is it needed?
> (why not just keep these files in ash[/common]/system?)

It's going to end up being 4 files. //ash/system/ tends to have each feature in
a subdirectory, so that's why I added one for /update.

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update_unittest.cc (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update_unittest.cc:21: TrayUpdate* tray_update =
GetPrimarySystemTray()->GetTrayUpdateForTesting();
On 2016/06/13 21:18:57, msw wrote:
> On 2016/06/13 20:56:26, James Cook wrote:
> > AshTestBase::GetPrimarySystemTray() is a dodge around DEPS. I'd like to try
to
> > avoid ash/shell.h from appearing anywhere in the DEPS files under
> //ash/common,
> > as I think it will tempt people to continue using it. However, quite a bit
of
> > the tray tests will need to look up a SystemTray from somewhere, and it's
> going
> > to be a while before I can move that one. WDYT?
> 
> 
> Why not add a WmShell interface function that returns nullptr on mus for now,
> and ash::Shell::instance()->GetPrimarySystemTray() for aura? I don't actually
> have a strong opinion, this dodge seems fine as a temporary measure, and it's
> probably okay to just delay moving the test files until we fix their deps.

As discussed offline, I'd prefer not to introduce a
WmShell::GetPrimarySystemTray(), since I don't want to encourage people to get
the "primary" system tray. I'm also a little nervous about introducing getters
for classes that haven't moved to //ash/common yet, and that return nullptr only
on mus. I'd prefer to wait.

[msw, 2016-06-13 22:11:13]

lgtm

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update.h (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update.h:5: #ifndef
ASH_COMMON_SYSTEM_UPDATE_TRAY_UPDATE_H_
On 2016/06/13 21:57:19, James Cook wrote:
> On 2016/06/13 21:18:57, msw wrote:
> > How much more will wind up in the update subfolder? Is it needed?
> > (why not just keep these files in ash[/common]/system?)
> 
> It's going to end up being 4 files. //ash/system/ tends to have each feature
in
> a subdirectory, so that's why I added one for /update.

Acknowledged.

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
File ash/common/system/update/tray_update_unittest.cc (right):

https://codereview.chromium.org/2059383002/diff/20001/ash/common/system/updat...
ash/common/system/update/tray_update_unittest.cc:21: TrayUpdate* tray_update =
GetPrimarySystemTray()->GetTrayUpdateForTesting();
On 2016/06/13 21:57:19, James Cook wrote:
> On 2016/06/13 21:18:57, msw wrote:
> > On 2016/06/13 20:56:26, James Cook wrote:
> > > AshTestBase::GetPrimarySystemTray() is a dodge around DEPS. I'd like to
try
> to
> > > avoid ash/shell.h from appearing anywhere in the DEPS files under
> > //ash/common,
> > > as I think it will tempt people to continue using it. However, quite a bit
> of
> > > the tray tests will need to look up a SystemTray from somewhere, and it's
> > going
> > > to be a while before I can move that one. WDYT?
> > 
> > 
> > Why not add a WmShell interface function that returns nullptr on mus for
now,
> > and ash::Shell::instance()->GetPrimarySystemTray() for aura? I don't
actually
> > have a strong opinion, this dodge seems fine as a temporary measure, and
it's
> > probably okay to just delay moving the test files until we fix their deps.
> 
> As discussed offline, I'd prefer not to introduce a
> WmShell::GetPrimarySystemTray(), since I don't want to encourage people to get
> the "primary" system tray. I'm also a little nervous about introducing getters
> for classes that haven't moved to //ash/common yet, and that return nullptr
only
> on mus. I'd prefer to wait.

Acknowledged.

[James Cook, 2016-06-13 22:17:20]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-13 22:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2059383002/40001

[commit-bot: I haz the power, 2016-06-13 23:54:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 23:56:38]

Description was changed from

==========
mash: Move TrayUpdate to //ash/common

It no longer has aura or ash::Shell dependencies.

Allow +ash/test in ash/common/system/DEPS because it's important for tests to
sit next to their implementation code, even if ash/test hasn't been converted
away from aura yet.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Move TrayUpdate to //ash/common

It no longer has aura or ash::Shell dependencies.

Allow +ash/test in ash/common/system/DEPS because it's important for tests to
sit next to their implementation code, even if ash/test hasn't been converted
away from aura yet.

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16
Cr-Commit-Position: refs/heads/master@{#399606}
==========

[commit-bot: I haz the power, 2016-06-13 23:56:39]

Patchset 3 (id:??) landed as
https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16
Cr-Commit-Position: refs/heads/master@{#399606}