components/ntp_snippets_strings.grdp - Issue 2061803002: 📰 The Status card reports disabled sync states

Unified Diff: components/ntp_snippets_strings.grdp

Issue 2061803002: 📰 The Status card reports disabled sync states (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplifyBridge

Patch Set: Refactor out status detection, update tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/ntp_snippets_test_utils.cc ('K') | « components/ntp_snippets/ntp_snippets_test_utils.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets_strings.grdp

diff --git a/components/ntp_snippets_strings.grdp b/components/ntp_snippets_strings.grdp

new file mode 100644

index 0000000000000000000000000000000000000000..29e404fd3d2f021bd9aea09d7bf4c35d7bdc4179

--- /dev/null

+++ b/components/ntp_snippets_strings.grdp

@@ -0,0 +1,28 @@

+<?xml version="1.0" encoding="utf-8"?>

+<grit-part>

+ <if expr="is_android">

+ <message name="IDS_SNIPPETS_DISABLED_SIGNED_OUT_INSTRUCTIONS" desc="Body of the card explaining the status of the ntp suggested content, when the user is signed out." formatter_data="android_java">

Bernhard Bauer 2016/06/28 13:47:39 Nit: "NTP" (also below)

dgn 2016/06/28 16:38:57 Done.

+ To get personalized content suggested by Google, sign in to Chrome.

Bernhard Bauer 2016/06/28 13:47:39 If this message mentions Chrome, it should be in .

dgn 2016/06/28 16:38:57 Acknowledged.

+ </message>

+ <message name="IDS_SNIPPETS_DISABLED_GENERIC_PROMPT" desc="Title of the card explaining what action the user can take to get suggested content on the NTP." formatter_data="android_java">

+ Get suggested content

+ </message>

+ <message name="IDS_SNIPPETS_DISABLED_SYNC_INSTRUCTIONS" desc="Body of the card explaining the status of the ntp suggested content, when sync is disabled." formatter_data="android_java">

+ To get personalized content suggested by Google, turn on sync.

Bernhard Bauer 2016/06/28 13:47:39 I assume these strings have been signed off? In pa

dgn 2016/06/28 16:38:57 Rachel said that the ones from the slides are the

+ </message>

+ <message name="IDS_SNIPPETS_DISABLED_SYNC_ACTION" desc="Label of the action button for the card explaining the status of the ntp suggested content, when sync is disabled." formatter_data="android_java">

+ Turn on sync

+ </message>

+ <message name="IDS_SNIPPETS_DISABLED_HISTORY_SYNC_INSTRUCTIONS" desc="Body of the card explaining the status of the ntp suggested content, when history sync is disabled." formatter_data="android_java">

+ To get personalized content suggested by Google, turn on history sync.

+ </message>

+ <message name="IDS_SNIPPETS_DISABLED_HISTORY_SYNC_ACTION" desc="Label of the action button for the card explaining the status of the ntp suggested content, when history sync is disabled." formatter_data="android_java">

+ Turn on history sync

+ </message>

+ <message name="IDS_SNIPPETS_DISABLED_PASSPHRASE_INSTRUCTIONS" desc="Body of the card explaining the status of the ntp suggested content, when passphrase encryption is enabled." formatter_data="android_java">

+ Personalized content suggestions are currently disabled, because your synced data is protected with a custom passphrase.

+ </message>

+ </if>

+</grit-part>