components/ntp_snippets_strings.grdp - Issue 2061803002: 📰 The Status card reports disabled sync states

Side by Side Diff: components/ntp_snippets_strings.grdp

Issue 2061803002: 📰 The Status card reports disabled sync states (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplifyBridge

Patch Set: Refactor out status detection, update tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_snippets/ntp_snippets_test_utils.cc ('K') | « components/ntp_snippets/ntp_snippets_test_utils.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3

	4 <if expr="is_android">

	5 <message name="IDS_SNIPPETS_DISABLED_SIGNED_OUT_INSTRUCTIONS" desc="Body of the card explaining the status of the ntp suggested content, when the user is si gned out." formatter_data="android_java">
	Bernhard Bauer 2016/06/28 13:47:39 Nit: "NTP" (also below) Nit: "NTP" (also below) dgn 2016/06/28 16:38:57 Done. Show quoted text On 2016/06/28 13:47:39, Bernhard Bauer wrote: > Nit: "NTP" (also below) Done.
	6 To get personalized content suggested by Google, sign in to Chrome.
	Bernhard Bauer 2016/06/28 13:47:39 If this message mentions Chrome, it should be in . If this message mentions Chrome, it should be in ...chromium_strings.grdp (with a counterpart in ...google_chrome_strings.grdp). But then again we're pretty bad about this on Android 😕 dgn 2016/06/28 16:38:57 Acknowledged. Show quoted text On 2016/06/28 13:47:39, Bernhard Bauer wrote: > If this message mentions Chrome, it should be in ...chromium_strings.grdp (with > a counterpart in ...google_chrome_strings.grdp). But then again we're pretty bad > about this on Android 😕 Acknowledged.
	7 </message>

	8 <message name="IDS_SNIPPETS_DISABLED_GENERIC_PROMPT" desc="Title of the card explaining what action the user can take to get suggested content on the NTP." formatter_data="android_java">

	9 Get suggested content

	10 </message>

	11 <message name="IDS_SNIPPETS_DISABLED_SYNC_INSTRUCTIONS" desc="Body of the ca rd explaining the status of the ntp suggested content, when sync is disabled." f ormatter_data="android_java">

	12 To get personalized content suggested by Google, turn on sync.
	Bernhard Bauer 2016/06/28 13:47:39 I assume these strings have been signed off? In pa I assume these strings have been signed off? In particular, lowercase "sync" is fine? dgn 2016/06/28 16:38:57 Rachel said that the ones from the slides are the Show quoted text On 2016/06/28 13:47:39, Bernhard Bauer wrote: > I assume these strings have been signed off? In particular, lowercase "sync" is > fine? Rachel said that the ones from the slides are the validated strings. There are already some cases of lowercase "sync" usage: https://cs.chromium.org/chromium/src/components/sync_ui_strings.grdp?q=f:grd+...
	13 </message>

	14 <message name="IDS_SNIPPETS_DISABLED_SYNC_ACTION" desc="Label of the action button for the card explaining the status of the ntp suggested content, when syn c is disabled." formatter_data="android_java">

	15 Turn on sync

	16 </message>

	17 <message name="IDS_SNIPPETS_DISABLED_HISTORY_SYNC_INSTRUCTIONS" desc="Body o f the card explaining the status of the ntp suggested content, when history sync is disabled." formatter_data="android_java">

	18 To get personalized content suggested by Google, turn on history sync.

	19 </message>

	20 <message name="IDS_SNIPPETS_DISABLED_HISTORY_SYNC_ACTION" desc="Label of the action button for the card explaining the status of the ntp suggested content, when history sync is disabled." formatter_data="android_java">

	21 Turn on history sync

	22 </message>

	23 <message name="IDS_SNIPPETS_DISABLED_PASSPHRASE_INSTRUCTIONS" desc="Body of the card explaining the status of the ntp suggested content, when passphrase enc ryption is enabled." formatter_data="android_java">

	24 Personalized content suggestions are currently disabled, because your sync ed data is protected with a custom passphrase.

	25 </message>

	26 </if>

	27

	28 </grit-part>

OLD	NEW