Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 2061743003: Remove unused ChildProcessService#getContext() (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ChildProcessService#getContext() BUG=None Committed: https://crrev.com/0223dd1f512839cfba8bbbcae456115cca06dd74 Cr-Commit-Position: refs/heads/master@{#400173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
pkotwicz
dtrainor@ can you please take a look? I am concerned that ChildProcessService#getContext() was added as ...
4 years, 6 months ago (2016-06-14 00:37:06 UTC) #2
pkotwicz
dtrainor@ Ping!
4 years, 6 months ago (2016-06-15 02:54:54 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 6 months ago (2016-06-16 15:53:29 UTC) #4
David Trainor- moved to gerrit
Sorry I missed this I was out at a convergence for the past two days.
4 years, 6 months ago (2016-06-16 15:53:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061743003/1
4 years, 6 months ago (2016-06-16 15:57:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 16:41:48 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 16:41:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:43:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0223dd1f512839cfba8bbbcae456115cca06dd74
Cr-Commit-Position: refs/heads/master@{#400173}

Powered by Google App Engine
This is Rietveld 408576698