Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2061383002: [UI Views] Unset the extension keybinding registry on frame destruction (Closed)

Created:
4 years, 6 months ago by Devlin
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[UI Views] Unset the extension keybinding registry on frame destruction Some destruction flows don't seem to call OnWidgetActivationChanged before destroying the window, which causes the extension keybinding registry reference in the global registry to become stale. Update the active registry on deletion. BUG=616970 Review-Url: https://codereview.chromium.org/2046653002 Cr-Commit-Position: refs/heads/master@{#398167} (cherry picked from commit fbcfdaeb71885d8081579746bedfbc6c5b813f11) Committed: https://chromium.googlesource.com/chromium/src/+/d83d3d08c885706910d00402cfec79cef265b665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 6 months ago (2016-06-14 23:54:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d83d3d08c885706910d00402cfec79cef265b665.

Powered by Google App Engine
This is Rietveld 408576698