Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2046653002: [UI Views] Unset the extension keybinding registry on frame destruction (Closed)

Created:
4 years, 6 months ago by Devlin
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UI Views] Unset the extension keybinding registry on frame destruction Some destruction flows don't seem to call OnWidgetActivationChanged before destroying the window, which causes the extension keybinding registry reference in the global registry to become stale. Update the active registry on deletion. BUG=616970 Committed: https://crrev.com/fbcfdaeb71885d8081579746bedfbc6c5b813f11 Cr-Commit-Position: refs/heads/master@{#398167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Scott, mind taking a look?
4 years, 6 months ago (2016-06-06 17:28:43 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-06 21:45:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046653002/1
4 years, 6 months ago (2016-06-06 23:26:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 00:16:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:18:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbcfdaeb71885d8081579746bedfbc6c5b813f11
Cr-Commit-Position: refs/heads/master@{#398167}

Powered by Google App Engine
This is Rietveld 408576698