Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issue 2061243002: Encode and decode fields of union type. (Closed)

Created:
4 years, 6 months ago by azani
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -3 lines) Patch
M mojom/generators/go/templates/decoding.go View 2 chunks +23 lines, -2 lines 0 comments Download
M mojom/generators/go/templates/decoding_test.go View 1 chunk +68 lines, -0 lines 0 comments Download
M mojom/generators/go/templates/encoding.go View 2 chunks +16 lines, -1 line 0 comments Download
M mojom/generators/go/templates/encoding_test.go View 3 chunks +82 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/mojom_file.go View 3 chunks +47 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/translator.go View 3 chunks +10 lines, -0 lines 0 comments Download
M mojom/generators/go/translator/translator_test.go View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
azani
4 years, 6 months ago (2016-06-14 17:30:01 UTC) #1
vardhan
lgtm
4 years, 6 months ago (2016-06-14 19:05:29 UTC) #2
azani
4 years, 6 months ago (2016-06-14 19:07:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6ed9f4483b9e7713af101999d95e9a436040126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698