Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: mojom/generators/go/translator/translator.go

Issue 2061243002: Encode and decode fields of union type. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojom/generators/go/translator/mojom_file.go ('k') | mojom/generators/go/translator/translator_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojom/generators/go/translator/translator.go
diff --git a/mojom/generators/go/translator/translator.go b/mojom/generators/go/translator/translator.go
index 7629754cf8e6758278270d0d31476fb08520cd28..6864f4ad63d72d159f194d7cbe5b1997f65d22aa 100644
--- a/mojom/generators/go/translator/translator.go
+++ b/mojom/generators/go/translator/translator.go
@@ -121,6 +121,9 @@ func (t *translator) translateUnionField(mojomField *mojom_types.UnionField) (fi
field.Tag = mojomField.Tag
field.EncodingInfo = t.encodingInfo(mojomField.Type)
field.EncodingInfo.setIdentifier("u.Value")
+ if info, ok := field.EncodingInfo.(*unionTypeEncodingInfo); ok {
+ info.nestedUnion = true
+ }
return field
}
@@ -254,6 +257,8 @@ func (t *translator) typeRefEncodingInfo(typeRef mojom_types.TypeReference) (inf
switch m := mojomType.(type) {
case *mojom_types.UserDefinedTypeStructType:
info = t.structTypeEncodingInfo(m.Value)
+ case *mojom_types.UserDefinedTypeUnionType:
+ info = t.unionTypeEncodingInfo(m.Value)
}
info.setNullable(typeRef.Nullable)
return info
@@ -264,6 +269,11 @@ func (t *translator) structTypeEncodingInfo(mojomType mojom_types.MojomStruct) (
return info
}
+func (t *translator) unionTypeEncodingInfo(mojomType mojom_types.MojomUnion) (info *unionTypeEncodingInfo) {
+ info = new(unionTypeEncodingInfo)
+ return info
+}
+
// Implements sort.Interface.
type structFieldSerializationSorter []mojom_types.StructField
« no previous file with comments | « mojom/generators/go/translator/mojom_file.go ('k') | mojom/generators/go/translator/translator_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698