remote_run: use /b as base directory for temporary files when available

remote_run: use /b as base directory for temporary files when available

See https://codereview.chromium.org/2049053002 and https://goto.google.com/vrpdd
(Google-internal) for context.

BUG=593999
Committed: https://chromium.googlesource.com/chromium/tools/build/+/98122d8810af966ebd7da62629c688c1ab6c8c9a

[Paweł Hajdan Jr., 2016-06-14 14:05:51]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 14:06:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061213002/1

[commit-bot: I haz the power, 2016-06-14 14:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 14:10:32]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-06-14 14:12:27]

phajdan.jr@chromium.org changed reviewers:
+ dnj@chromium.org, estaab@chromium.org, iannucci@chromium.org,
martiniss@chromium.org, vadimsh@chromium.org

[estaab, 2016-06-14 16:57:36]

lgtm

https://codereview.chromium.org/2061213002/diff/1/scripts/common/chromium_uti...
File scripts/common/chromium_utils.py (right):

https://codereview.chromium.org/2061213002/diff/1/scripts/common/chromium_uti...
scripts/common/chromium_utils.py:818: if found_path.endswith(os.sep) and
os.path.dirname(found_path) != found_path:
This changes the behavior of this function so if someone was depending on it to
return the root when the path wasn't found it will break now, so perhaps watch
for breakage after this goes in.

[Paweł Hajdan Jr., 2016-06-15 07:59:10]

https://codereview.chromium.org/2061213002/diff/1/scripts/common/chromium_uti...
File scripts/common/chromium_utils.py (right):

https://codereview.chromium.org/2061213002/diff/1/scripts/common/chromium_uti...
scripts/common/chromium_utils.py:818: if found_path.endswith(os.sep) and
os.path.dirname(found_path) != found_path:
On 2016/06/14 at 16:57:36, estaab wrote:
> This changes the behavior of this function so if someone was depending on it
to return the root when the path wasn't found it will break now, so perhaps
watch for breakage after this goes in.

Yup. FWIW, Windows might also be funny - I'll definitely watch out. Landing this
early my local time.

[Paweł Hajdan Jr., 2016-06-15 07:59:16]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-06-15 07:59:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061213002/1

[commit-bot: I haz the power, 2016-06-15 08:02:54]

Description was changed from

==========
remote_run: use /b as base directory for temporary files when available

See https://codereview.chromium.org/2049053002 and https://goto.google.com/vrpdd
(Google-internal) for context.

BUG=593999
==========

to

==========
remote_run: use /b as base directory for temporary files when available

See https://codereview.chromium.org/2049053002 and https://goto.google.com/vrpdd
(Google-internal) for context.

BUG=593999

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/98122d8810af966ebd7d...
==========

[commit-bot: I haz the power, 2016-06-15 08:02:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/98122d8810af966ebd7d...