remote_run: use tempfile.gettempdir() for workdirs

remote_run: use tempfile.gettempdir() for workdirs

Otherwise we run into long path issues at least on Windows and Linux.

BUG=617565, 593999
Committed: https://chromium.googlesource.com/chromium/tools/build/+/de4940e6299d9d5c4d9183574cdba5dc1b72bd15

[Paweł Hajdan Jr., 2016-06-08 13:20:29]

phajdan.jr@chromium.org changed reviewers:
+ sergiyb@chromium.org, tandrii@chromium.org

[tandrii(chromium), 2016-06-08 13:28:29]

LGTM % though we did have an issue with macs on swarming remove some stuff from
its temp dir.

[Paweł Hajdan Jr., 2016-06-08 13:29:00]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-06-08 13:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049053002/1

[commit-bot: I haz the power, 2016-06-08 13:33:26]

Description was changed from

==========
remote_run: use tempfile.gettempdir() for workdirs

Otherwise we run into long path issues at least on Windows and Linux.

BUG=617565, 593999
==========

to

==========
remote_run: use tempfile.gettempdir() for workdirs

Otherwise we run into long path issues at least on Windows and Linux.

BUG=617565, 593999

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/de4940e6299d9d5c4d91...
==========

[commit-bot: I haz the power, 2016-06-08 13:33:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/de4940e6299d9d5c4d91...

[Vadim Sh., 2016-06-08 18:48:11]

this patch makes me sad :(

1) tempdir may be on a small partition (e.g. C:\ on Windows instead of huge E:\)
2) If something breaks and start leaking temp files, we'll never know, because
system temp dir is full of stuff all the time and no one looks there.
3) In general. /tmp is often mounted as noexec.

If the path is too long, maybe it's better to figure out what makes it long and
make it shorter?

[iannucci1, 2016-06-08 18:55:29]

On 2016/06/08 18:48:11, Vadim Sh. wrote:
> this patch makes me sad :(
> 
> 1) tempdir may be on a small partition (e.g. C:\ on Windows instead of huge
E:\)
> 2) If something breaks and start leaking temp files, we'll never know, because
> system temp dir is full of stuff all the time and no one looks there.
> 3) In general. /tmp is often mounted as noexec.
> 
> If the path is too long, maybe it's better to figure out what makes it long
and
> make it shorter?

ack :( Yeah we can't use the tempdir. This should be put under something else.

[Paweł Hajdan Jr., 2016-06-09 14:26:02]

Thanks for the comments, and Andrii for pointing me to them (I filter lots of
emails and so usually don't notice comments on closed CLs).

Please see https://goto.google.com/vrpdd for my follow-up.