Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2061163003: include stdlib.h when using calloc (Closed)

Created:
4 years, 6 months ago by Mostyn Bramley-Moore
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

include stdlib.h when using calloc Small followup to https://codereview.chromium.org/2042253002 BUG=chromium:616033 Committed: https://crrev.com/9d12ad0df01b6aa5cff5b0ae1a7b83a854fd965e Cr-Commit-Position: refs/heads/master@{#36992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/base/file-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061163003/1
4 years, 6 months ago (2016-06-15 08:22:44 UTC) #2
Mostyn Bramley-Moore
@Yang: can you please rubber-stamp this?
4 years, 6 months ago (2016-06-15 08:24:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 08:52:16 UTC) #6
Yang
On 2016/06/15 08:52:16, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-06-15 08:54:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061163003/1
4 years, 6 months ago (2016-06-15 08:55:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 08:57:28 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 08:58:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d12ad0df01b6aa5cff5b0ae1a7b83a854fd965e
Cr-Commit-Position: refs/heads/master@{#36992}

Powered by Google App Engine
This is Rietveld 408576698