ash/common/system/chromeos/DEPS - Issue 2061123004: mash: Move //ash/system/date to //ash/common

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/system/chromeos/DEPS

Issue 2061123004: mash: Move //ash/system/date to //ash/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@uma

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+chromeos",	2 "+chromeos",
	msw 2016/06/14 23:11:42 Nice, src/chromeos doesn't use aura! I suppose thi Nice, src/chromeos doesn't use aura! I suppose this dep is ok. James Cook 2016/06/14 23:24:21 Acknowledged. Show quoted text On 2016/06/14 23:11:42, msw wrote: > Nice, src/chromeos doesn't use aura! I suppose this dep is ok. Acknowledged.
3 "+grit/ui_chromeos_resources.h",	3 "+grit/ui_chromeos_resources.h",
	msw 2016/06/14 23:11:42 nit: these grit DEPS aren't used yet; delay adding nit: these grit DEPS aren't used yet; delay adding until needed? James Cook 2016/06/14 23:24:21 Done. Show quoted text On 2016/06/14 23:11:42, msw wrote: > nit: these grit DEPS aren't used yet; delay adding until needed? Done.
4 "+grit/ui_chromeos_strings.h",	4 "+grit/ui_chromeos_strings.h",

5 ]	5 ]

OLD	NEW