Unmute Tab Audio For Desktop Share By Default

Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.

BUG=595428
Committed: https://crrev.com/4534e544153d04f43759bcdba32a03fb7cb45c92
Cr-Commit-Position: refs/heads/master@{#401054}

[qiangchen, 2016-06-13 17:20:53]

Description was changed from

==========
Unmute Tab Audio For Desktop Share

BUG=
==========

to

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.


BUG=
==========

[qiangchen, 2016-06-13 17:20:54]

qiangchen@chromium.org changed reviewers:
+ miu@chromium.org

[qiangchen, 2016-06-13 17:21:30]

qiangchen@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[qiangchen, 2016-06-13 17:22:23]

Description was changed from

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.


BUG=
==========

to

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.

BUG=595428
==========

[qiangchen, 2016-06-13 17:53:31]

Patchset #1 (id:1) has been deleted

[qiangchen, 2016-06-13 17:54:12]

The CL make the audio duplication work for tab typed desktop capture.

[DaleCurtis, 2016-06-13 20:41:08]

lgtm mechanically, but defer to miu@ for functionality.

[miu, 2016-06-20 20:42:00]

lgtm, but one thing to address before committing:

https://codereview.chromium.org/2060963002/diff/20001/content/browser/media/c...
File content/browser/media/capture/web_contents_audio_input_stream.cc (right):

https://codereview.chromium.org/2060963002/diff/20001/content/browser/media/c...
content/browser/media/capture/web_contents_audio_input_stream.cc:361: //
TODO(qiangchen): Plug in true for the case of Tab Typed Desktop Share.
Looks like you can remove this TODO comment now. ;-)

[qiangchen, 2016-06-21 16:12:15]

https://codereview.chromium.org/2060963002/diff/20001/content/browser/media/c...
File content/browser/media/capture/web_contents_audio_input_stream.cc (right):

https://codereview.chromium.org/2060963002/diff/20001/content/browser/media/c...
content/browser/media/capture/web_contents_audio_input_stream.cc:361: //
TODO(qiangchen): Plug in true for the case of Tab Typed Desktop Share.
On 2016/06/20 20:42:00, miu wrote:
> Looks like you can remove this TODO comment now. ;-)

Done.

[qiangchen, 2016-06-21 18:31:10]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2016-06-21 18:31:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2060963002/#ps40001
(title: "Remove old TODO")

[commit-bot: I haz the power, 2016-06-21 18:32:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060963002/40001

[commit-bot: I haz the power, 2016-06-21 18:45:36]

Description was changed from

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.

BUG=595428
==========

to

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.

BUG=595428
==========

[commit-bot: I haz the power, 2016-06-21 18:45:37]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-21 18:50:06]

Description was changed from

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.

BUG=595428
==========

to

==========
Unmute Tab Audio For Desktop Share By Default

We did an enhancement to support audio for desktop share.
However, using the existing framework, we found a deficiency:
During the tab sharing with audio, on the sender side, we
cannot hear the sound.
The main reason is that we divert the audio stream to
WebContentsAudioInputStream, and no longer serve the speaker.

In previous CL, we make the code path capable of duplicating
audio data. In this CL, we make the duplication to be the default
behavior for audio type MEDIA_DESKTOP_AUDIO_CAPTURE.

BUG=595428

Committed: https://crrev.com/4534e544153d04f43759bcdba32a03fb7cb45c92
Cr-Commit-Position: refs/heads/master@{#401054}
==========

[commit-bot: I haz the power, 2016-06-21 18:50:08]

Patchset 2 (id:??) landed as
https://crrev.com/4534e544153d04f43759bcdba32a03fb7cb45c92
Cr-Commit-Position: refs/heads/master@{#401054}