Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: content/browser/media/capture/web_contents_audio_input_stream.cc

Issue 2060963002: Unmute Tab Audio For Desktop Share By Default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove old TODO Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/capture/web_contents_audio_input_stream.cc
diff --git a/content/browser/media/capture/web_contents_audio_input_stream.cc b/content/browser/media/capture/web_contents_audio_input_stream.cc
index 9ca7b585dbc901ddea64b31c70e7ab22b3058374..4a58cc34c090837a49ec652fc2e30ab040bb0a4d 100644
--- a/content/browser/media/capture/web_contents_audio_input_stream.cc
+++ b/content/browser/media/capture/web_contents_audio_input_stream.cc
@@ -349,7 +349,8 @@ WebContentsAudioInputStream* WebContentsAudioInputStream::Create(
const std::string& device_id,
const media::AudioParameters& params,
const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner,
- AudioMirroringManager* audio_mirroring_manager) {
+ AudioMirroringManager* audio_mirroring_manager,
+ bool is_duplication) {
int render_process_id;
int main_render_frame_id;
if (!WebContentsMediaCaptureId::ExtractTabCaptureTarget(
@@ -357,14 +358,13 @@ WebContentsAudioInputStream* WebContentsAudioInputStream::Create(
return NULL;
}
- // TODO(qiangchen): Plug in true for the case of Tab Typed Desktop Share.
return new WebContentsAudioInputStream(
render_process_id, main_render_frame_id, audio_mirroring_manager,
new WebContentsTracker(false),
new media::VirtualAudioInputStream(
params, worker_task_runner,
media::VirtualAudioInputStream::AfterCloseCallback()),
- false);
+ is_duplication);
}
WebContentsAudioInputStream::WebContentsAudioInputStream(

Powered by Google App Engine
This is Rietveld 408576698