Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: content/browser/media/session/pepper_player_delegate.h

Issue 2060933002: Let Flash join and be controlled by media session (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pepper_to_contents
Patch Set: addressed Mounir's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/pepper_player_delegate.h
diff --git a/content/browser/media/session/pepper_player_delegate.h b/content/browser/media/session/pepper_player_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..bf9fe9cd95e4731c0544a9a7a6cf168eba9a81fa
--- /dev/null
+++ b/content/browser/media/session/pepper_player_delegate.h
@@ -0,0 +1,36 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_SESSION_PEPPER_PLAYER_DELEGATE_H_
+#define CONTENT_BROWSER_MEDIA_SESSION_PEPPER_PLAYER_DELEGATE_H_
+
+#include "content/browser/media/session/media_session_observer.h"
+#include "ppapi/c/pp_instance.h"
+
+namespace content {
+
+class PepperWebContentsObserver;
+
+class PepperPlayerDelegate : public MediaSessionObserver {
+ public:
+ PepperPlayerDelegate(
+ PepperWebContentsObserver* pepper_web_contents_observer,
+ PP_Instance pp_instance);
+ ~PepperPlayerDelegate() override;
+
+ void OnSuspend(int player_id) override;
jochen (gone - plz use gerrit) 2016/06/27 11:47:11 add a comment like // MediaSessionObserver impleme
Zhiqiang Zhang (Slow) 2016/06/28 18:53:24 Done.
+ void OnResume(int player_id) override;
+ void OnSetVolumeMultiplier(int player_id,
+ double volume_multiplier) override;
+
+ void OnSetVolume(int player_id, double volume);
jochen (gone - plz use gerrit) 2016/06/27 11:47:11 this should be private and be named SetVolume
Zhiqiang Zhang (Slow) 2016/06/28 18:53:24 Done.
+
+ private:
+ PepperWebContentsObserver* pepper_web_contents_observer_;
+ PP_Instance pp_instance_;
+};
jochen (gone - plz use gerrit) 2016/06/27 11:47:11 disallow copy & assign
Zhiqiang Zhang (Slow) 2016/06/28 18:53:24 Done.
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_MEDIA_SESSION_PEPPER_PLAYER_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698