Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: content/browser/media/session/pepper_player_delegate.h

Issue 2060933002: Let Flash join and be controlled by media session (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pepper_to_contents
Patch Set: addressed Mounir's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_MEDIA_SESSION_PEPPER_PLAYER_DELEGATE_H_
6 #define CONTENT_BROWSER_MEDIA_SESSION_PEPPER_PLAYER_DELEGATE_H_
7
8 #include "content/browser/media/session/media_session_observer.h"
9 #include "ppapi/c/pp_instance.h"
10
11 namespace content {
12
13 class PepperWebContentsObserver;
14
15 class PepperPlayerDelegate : public MediaSessionObserver {
16 public:
17 PepperPlayerDelegate(
18 PepperWebContentsObserver* pepper_web_contents_observer,
19 PP_Instance pp_instance);
20 ~PepperPlayerDelegate() override;
21
22 void OnSuspend(int player_id) override;
jochen (gone - plz use gerrit) 2016/06/27 11:47:11 add a comment like // MediaSessionObserver impleme
Zhiqiang Zhang (Slow) 2016/06/28 18:53:24 Done.
23 void OnResume(int player_id) override;
24 void OnSetVolumeMultiplier(int player_id,
25 double volume_multiplier) override;
26
27 void OnSetVolume(int player_id, double volume);
jochen (gone - plz use gerrit) 2016/06/27 11:47:11 this should be private and be named SetVolume
Zhiqiang Zhang (Slow) 2016/06/28 18:53:24 Done.
28
29 private:
30 PepperWebContentsObserver* pepper_web_contents_observer_;
31 PP_Instance pp_instance_;
32 };
jochen (gone - plz use gerrit) 2016/06/27 11:47:11 disallow copy & assign
Zhiqiang Zhang (Slow) 2016/06/28 18:53:24 Done.
33
34 } // namespace content
35
36 #endif // CONTENT_BROWSER_MEDIA_SESSION_PEPPER_PLAYER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698