Oilpan: move Console objects to the oilpan heap.

Source/core/frame/ConsoleBase.h

Index: Source/core/frame/ConsoleBase.h
diff --git a/Source/core/frame/ConsoleBase.h b/Source/core/frame/ConsoleBase.h
index 30858d02731c7ea1f4b7b848787a6a7801eec62b..0755b5ccc010e896b2e8ce37e3d4b6e94cfc7a27 100644
--- a/Source/core/frame/ConsoleBase.h
+++ b/Source/core/frame/ConsoleBase.h
@@ -36,6 +36,7 @@
 #include "core/inspector/ScriptCallStack.h"
 #include "core/frame/ConsoleTypes.h"
 #include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
@@ -44,10 +45,12 @@ namespace WebCore {
 
 class ScriptArguments;
 
-class ConsoleBase {
+class ConsoleBase : public NoBaseWillBeGarbageCollectedFinalized<ConsoleBase> {
 public:
+#if !ENABLE(OILPAN)
     void ref() { refConsole(); }

[Mads Ager (chromium), 2014/03/20 14:20:01]

WAT!?! What is this, I don't even?!?

Why isn't ConsoleBase just RefCounted<ConsoleBase>? I would prefer if we can
clean this code up both for Oilpan and without Oilpan. However, I might be
missing something?

[sof, 2014/03/20 14:57:23]

Not missing anything, it definitely can be simplified so. Seems like extra
generality that turned out to be unnecessary when adding support for Console to
Workers.

Very well observed & questioned :) Made ConsoleBase derive from the transition
type RefCountedWillBeGarbageCollectedFinalized instead.

     void deref() { derefConsole(); }
+#endif
 
     void debug(ScriptState*, PassRefPtr<ScriptArguments>);
     void error(ScriptState*, PassRefPtr<ScriptArguments>);
@@ -73,14 +76,22 @@ public:
     void groupCollapsed(ScriptState*, PassRefPtr<ScriptArguments>);
     void groupEnd();
 
+    virtual void trace(Visitor*) { }
+
+#if !ENABLE(OILPAN)
 protected:
+#endif

[haraken, 2014/03/20 14:13:06]

I'd just remove protected: and make the destructor public even in the non-oilpan
build.

[sof, 2014/03/20 14:57:23]

yes; with RefCounted<> now on ConsoleBase the slightest concern I had about
doing this is gone.

     virtual ~ConsoleBase();
+
+protected:
     virtual ExecutionContext* context() = 0;
     virtual void reportMessageToClient(MessageLevel, const String& message, PassRefPtr<ScriptCallStack>) = 0;
 
 private:
+#if !ENABLE(OILPAN)
     virtual void refConsole() = 0;
     virtual void derefConsole() = 0;
+#endif
 
     void internalAddMessage(MessageType, MessageLevel, ScriptState*, PassRefPtr<ScriptArguments>, bool acceptNoArguments = false, bool printTrace = false);
 };