Oilpan: move Console objects to the oilpan heap.

Source/core/frame/ConsoleBase.h

 /*
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 18 matching lines @@
 
 #ifndef ConsoleBase_h
 #define ConsoleBase_h
 
 #include "bindings/v8/ScriptState.h"
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/inspector/ConsoleAPITypes.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "core/frame/ConsoleTypes.h"
 #include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
 class ScriptArguments;
 
-class ConsoleBase {
+class ConsoleBase : public NoBaseWillBeGarbageCollectedFinalized<ConsoleBase> {
 public:
+#if !ENABLE(OILPAN)
     void ref() { refConsole(); }

[Mads Ager (chromium), 2014/03/20 14:20:01]

WAT!?! What is this, I don't even?!?

Why isn't ConsoleBase just RefCounted<ConsoleBase>? I would prefer if we can
clean this code up both for Oilpan and without Oilpan. However, I might be
missing something?

[sof, 2014/03/20 14:57:23]

Not missing anything, it definitely can be simplified so. Seems like extra
generality that turned out to be unnecessary when adding support for Console to
Workers.

Very well observed & questioned :) Made ConsoleBase derive from the transition
type RefCountedWillBeGarbageCollectedFinalized instead.

     void deref() { derefConsole(); }
+#endif
 
     void debug(ScriptState*, PassRefPtr<ScriptArguments>);
     void error(ScriptState*, PassRefPtr<ScriptArguments>);
     void info(ScriptState*, PassRefPtr<ScriptArguments>);
     void log(ScriptState*, PassRefPtr<ScriptArguments>);
     void clear(ScriptState*, PassRefPtr<ScriptArguments>);
     void warn(ScriptState*, PassRefPtr<ScriptArguments>);
     void dir(ScriptState*, PassRefPtr<ScriptArguments>);
     void dirxml(ScriptState*, PassRefPtr<ScriptArguments>);
     void table(ScriptState*, PassRefPtr<ScriptArguments>);
     void trace(ScriptState*, PassRefPtr<ScriptArguments>);
     void assertCondition(ScriptState*, PassRefPtr<ScriptArguments>, bool condition);
     void count(ScriptState*, PassRefPtr<ScriptArguments>);
     void markTimeline(const String&);
     void profile(ScriptState*, const String&);
     void profileEnd(ScriptState*, const String&);
     void time(const String&);
     void timeEnd(ScriptState*, const String&);
     void timeStamp(const String&);
     void timeline(ScriptState*, const String&);
     void timelineEnd(ScriptState*, const String&);
     void group(ScriptState*, PassRefPtr<ScriptArguments>);
     void groupCollapsed(ScriptState*, PassRefPtr<ScriptArguments>);
     void groupEnd();
 
+    virtual void trace(Visitor*) { }
+
+#if !ENABLE(OILPAN)
 protected:
+#endif

[haraken, 2014/03/20 14:13:06]

I'd just remove protected: and make the destructor public even in the non-oilpan
build.

[sof, 2014/03/20 14:57:23]

yes; with RefCounted<> now on ConsoleBase the slightest concern I had about
doing this is gone.

     virtual ~ConsoleBase();
+
+protected:
     virtual ExecutionContext* context() = 0;
     virtual void reportMessageToClient(MessageLevel, const String& message, PassRefPtr<ScriptCallStack>) = 0;
 
 private:
+#if !ENABLE(OILPAN)
     virtual void refConsole() = 0;
     virtual void derefConsole() = 0;
+#endif
 
     void internalAddMessage(MessageType, MessageLevel, ScriptState*, PassRefPtr<ScriptArguments>, bool acceptNoArguments = false, bool printTrace = false);
 };
 
 } // namespace WebCore
 
 #endif // ConsoleBase_h