Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2060853002: Remove ineffective PendingScript prefinalizer (2nd attempt.) (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ineffective PendingScript prefinalizer (2nd attempt.) With the missing case from r397106 aboard, retire the prefinalizer for PendingScript. Script loader and runner objects are expected to explicitly dispose of these upon success or failure. R= BUG= Committed: https://crrev.com/fbf7f01ae80f666a5b37acf0ef38fd174443787f Cr-Commit-Position: refs/heads/master@{#399504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. I want to give this one another go; the shorter the ...
4 years, 6 months ago (2016-06-13 14:28:15 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-13 14:43:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060853002/1
4 years, 6 months ago (2016-06-13 15:40:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 19:12:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fbf7f01ae80f666a5b37acf0ef38fd174443787f Cr-Commit-Position: refs/heads/master@{#399504}
4 years, 6 months ago (2016-06-13 19:14:47 UTC) #8
sof
4 years, 6 months ago (2016-06-14 13:21:23 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2069573002/ by sigbjornf@opera.com.

The reason for reverting is: Canary crashes reported,

 https://bugs.chromium.org/p/chromium/issues/detail?id=615977#c12.

Powered by Google App Engine
This is Rietveld 408576698