third_party/WebKit/Source/core/dom/PendingScript.cpp - Issue 2060853002: Remove ineffective PendingScript prefinalizer (2nd attempt.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/PendingScript.cpp

Issue 2060853002: Remove ineffective PendingScript prefinalizer (2nd attempt.) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/PendingScript.cpp

diff --git a/third_party/WebKit/Source/core/dom/PendingScript.cpp b/third_party/WebKit/Source/core/dom/PendingScript.cpp

index 246e3260e2ac618e8c70291106713f6d9169b5f1..f23b31e3a9bb011c0a39d9ebe0bb93cf4b0c1c29 100644

--- a/third_party/WebKit/Source/core/dom/PendingScript.cpp

+++ b/third_party/WebKit/Source/core/dom/PendingScript.cpp

@@ -47,11 +47,12 @@ PendingScript::PendingScript(Element* element, ScriptResource* resource)

, m_client(nullptr)

{

setScriptResource(resource);

- ThreadState::current()->registerPreFinalizer(this);

}

PendingScript::~PendingScript()

{

+ // Verify explicit dispose().

+ CHECK(!m_client && !m_element && !m_streamer);

}

void PendingScript::dispose()

« no previous file with comments | « third_party/WebKit/Source/core/dom/PendingScript.h ('k') | no next file » | no next file with comments »