Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 206073009: Add the NSPR macro definitions for ARM64 bit. (Closed)

Created:
6 years, 9 months ago by Ted C
Modified:
6 years, 9 months ago
Reviewers:
Nico, wtc, rmcilroy, Ryan Sleevi
CC:
chromium-reviews, erikwright+watch_chromium.org, Nico
Visibility:
Public.

Description

Add the NSPR macro definitions for ARM64 bit. BUG=354405 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258430

Patch Set 1 #

Patch Set 2 : Use complete open source version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M base/third_party/nspr/prcpucfg_linux.h View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted C
PTAL
6 years, 9 months ago (2014-03-20 18:16:18 UTC) #1
Ryan Sleevi
Punting to wtc@
6 years, 9 months ago (2014-03-20 18:19:31 UTC) #2
wtc
Patch set 1 LGTM. I assume you copied this code from NSPR upstream: http://mxr.mozilla.org/nspr/source/pr/include/md/_linux.cfg
6 years, 9 months ago (2014-03-20 18:37:33 UTC) #3
Ted C
On 2014/03/20 18:37:33, wtc wrote: > Patch set 1 LGTM. I assume you copied this ...
6 years, 9 months ago (2014-03-20 18:50:16 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-20 18:53:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/206073009/20001
6 years, 9 months ago (2014-03-20 18:53:46 UTC) #6
wtc
Patch set 2 LGTM. Thanks.
6 years, 9 months ago (2014-03-20 18:53:54 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 22:05:37 UTC) #8
Message was sent while issue was closed.
Change committed as 258430

Powered by Google App Engine
This is Rietveld 408576698