Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 206073006: Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new (Closed)

Created:
6 years, 9 months ago by pneubeck (no reviews)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), jam, nkostylev+watch_chromium.org, tzik, Lei Zhang, tfarina, Greg Billock, nhiroki, joi+watch-content_chromium.org, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, cmumford, jsbell
Visibility:
Public.

Description

Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new (https://codereview.chromium.org/197233008/) Reason for revert: Best guess that this broke SyncFileSystemApiTest.WriteFileThenGetUsage on XP Tests(1). http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/30601/steps/browser_tests/logs/WriteFileThenGetUsage If not, we can just re-revert or reland it after a few cycles. Original issue's description: > Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new files as well as writing to existing files. > See https://codereview.chromium.org/18023022/ for context; this is needed by upcoming IDB Blob support. > > Tzik, please do primary review for filesystem; Kinaba, please review as ChromeOS owner. > > BUG=108012 > R=kinaba,tzik > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258120 TBR=kinaba@chromium.org,tzik@chromium.org,ericu@chromium.org NOTREECHECKS=true NOTRY=true BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -56 lines) Patch
M chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 6 chunks +17 lines, -9 lines 0 comments Download
M webkit/browser/fileapi/file_stream_writer.h View 1 chunk +1 line, -4 lines 0 comments Download
M webkit/browser/fileapi/isolated_file_system_backend.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.h View 2 chunks +1 line, -3 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.cc View 3 chunks +4 lines, -21 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pneubeck (no reviews)
Created Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new
6 years, 9 months ago (2014-03-20 08:40:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/206073006/1
6 years, 9 months ago (2014-03-20 08:40:38 UTC) #2
commit-bot: I haz the power
Change committed as 258256
6 years, 9 months ago (2014-03-20 08:42:23 UTC) #3
pneubeck (no reviews)
A revert of this CL has been created in https://codereview.chromium.org/206083004/ by pneubeck@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-20 09:10:11 UTC) #4
Bernhard Bauer
On 2014/03/20 09:10:11, pneubeck wrote: > A revert of this CL has been created in ...
6 years, 9 months ago (2014-03-20 09:19:45 UTC) #5
pneubeck (no reviews)
6 years, 9 months ago (2014-03-20 16:20:33 UTC) #6
Message was sent while issue was closed.
On 2014/03/20 09:19:45, Bernhard Bauer wrote:
> On 2014/03/20 09:10:11, pneubeck wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/206083004/ by mailto:pneubeck@chromium.org.
> > 
> > The reason for reverting is: Sorry, I looked through this CL in more detail
> and
> > it seems that it doesn't change any behavior.
> > 
> > Re-reverting this one and instead trying crrev.com/258064.
> 
> FYI, the first broken revision was crrev.com/258053 (see
>
http://build.chromium.org/p/chromium.win/builders/XP%2520Tests%2520%25281%252...)

Seems not to have caused the test failures.
See crbug.com/354425 for details.

Powered by Google App Engine
This is Rietveld 408576698