Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206073005: PassRefPtr is stolen by first agent invocation. (Closed)

Created:
6 years, 9 months ago by eustas
Modified:
6 years, 9 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

PassRefPtr is stolen by first agent invocation. BUG=353921 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169926

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed signatures #

Patch Set 3 : chmod #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M Source/core/inspector/CodeGeneratorInstrumentation.py View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 3 chunks +3 lines, -3 lines 1 comment Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
eustas
6 years, 9 months ago (2014-03-20 06:08:46 UTC) #1
eustas
6 years, 9 months ago (2014-03-20 06:09:13 UTC) #2
aandrey
lgtm https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/CodeGeneratorInstrumentation.py File Source/core/inspector/CodeGeneratorInstrumentation.py (right): https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/CodeGeneratorInstrumentation.py#newcode387 Source/core/inspector/CodeGeneratorInstrumentation.py:387: if re.match("PassRefPtr<", param_decl): maybe also PassOwnPtr? https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/InspectorInstrumentation.idl File ...
6 years, 9 months ago (2014-03-20 06:16:11 UTC) #3
aandrey
https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/InspectorDebuggerAgent.h File Source/core/inspector/InspectorDebuggerAgent.h (right): https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/InspectorDebuggerAgent.h#newcode96 Source/core/inspector/InspectorDebuggerAgent.h:96: void addMessageToConsole(MessageSource, MessageType, MessageLevel, const String&, PassRefPtr<ScriptCallStack>, unsigned long); ...
6 years, 9 months ago (2014-03-20 06:21:55 UTC) #4
Vladislav Kaznacheev
On 2014/03/20 06:21:55, aandrey wrote: > https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/InspectorDebuggerAgent.h > File Source/core/inspector/InspectorDebuggerAgent.h (right): > > https://codereview.chromium.org/206073005/diff/1/Source/core/inspector/InspectorDebuggerAgent.h#newcode96 > ...
6 years, 9 months ago (2014-03-20 06:27:49 UTC) #5
aandrey
On 2014/03/20 06:27:49, Vladislav Kaznacheev wrote: > On 2014/03/20 06:21:55, aandrey wrote: > > > ...
6 years, 9 months ago (2014-03-20 06:32:44 UTC) #6
eustas
Done. PTAL
6 years, 9 months ago (2014-03-24 14:08:28 UTC) #7
Vladislav Kaznacheev
lgtm
6 years, 9 months ago (2014-03-24 14:15:05 UTC) #8
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-24 14:27:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/206073005/20001
6 years, 9 months ago (2014-03-24 14:27:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 14:36:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-24 14:36:29 UTC) #12
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-24 14:50:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/206073005/30009
6 years, 9 months ago (2014-03-24 14:50:05 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 14:59:31 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-24 14:59:32 UTC) #16
aandrey
https://codereview.chromium.org/206073005/diff/30009/Source/core/inspector/InspectorConsoleAgent.cpp File Source/core/inspector/InspectorConsoleAgent.cpp (right): https://codereview.chromium.org/206073005/diff/30009/Source/core/inspector/InspectorConsoleAgent.cpp#newcode251 Source/core/inspector/InspectorConsoleAgent.cpp:251: addMessageToConsole(ConsoleAPIMessageSource, LogMessageType, DebugMessageLevel, message, callStack.get()); nit: get() -> release()
6 years, 9 months ago (2014-03-24 14:59:39 UTC) #17
aandrey
On 2014/03/24 14:59:39, aandrey wrote: > https://codereview.chromium.org/206073005/diff/30009/Source/core/inspector/InspectorConsoleAgent.cpp > File Source/core/inspector/InspectorConsoleAgent.cpp (right): > > https://codereview.chromium.org/206073005/diff/30009/Source/core/inspector/InspectorConsoleAgent.cpp#newcode251 > ...
6 years, 9 months ago (2014-03-24 15:30:24 UTC) #18
vsevik
lgtm
6 years, 9 months ago (2014-03-25 08:18:08 UTC) #19
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-25 08:23:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/206073005/30009
6 years, 9 months ago (2014-03-25 08:23:28 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 09:25:01 UTC) #22
Message was sent while issue was closed. 
Change committed as 169926

Powered by Google App Engine
This is Rietveld 408576698